-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] account_move_product: New module account_move_product #1992
base: 16.0
Are you sure you want to change the base?
Conversation
40a11fd
to
78d819a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the changes in account_asset_management
?
It looks like a dirty commit. Can you check it please?
expr="//field[@name='line_ids']//tree//field[@name='account_id']" | ||
position="after" | ||
> | ||
<field name="product_id" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add optional="show"
if someone wants to hide this information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your review! I fixed both issues, could you review again when you have a moment? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
7e09529
to
9c08508
Compare
9c08508
to
89953e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code review and tested in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be added in this other module as an improvement: https://github.com/OCA/stock-logistics-warehouse/tree/16.0/account_move_line_product
<?xml version="1.0" encoding="UTF-8" ?> | ||
<odoo> | ||
<record id="view_move_form_analytic_product" model="ir.ui.view"> | ||
<field name="name">account.move.form.analytic.product</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please put a better name in the view?
This module adds the product to journal entries.
New module account_move_product
cc https://github.com/APSL 164801
@miquelalzanillas @lbarry-apsl @BernatObrador @peluko00 @javierobcn @ppyczko please review