-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][OU-ADD] event: Migration scripts #4663
Conversation
/ocabot migration event |
I am not sure if the analysis is up to date, I just saw that (for example) the |
a8cc709
to
9aa113f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at ae606a8. Thanks a lot for contributing to OCA. ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victoralmau please fix my comments in an extra PR.
@MiquelRForgeFlow it's convenient to not merge this so lightly.
event / event.event / registration_properties_definition (properties_definition): NEW | ||
# NOTHING TO DO | ||
event / event.event.ticket / _order : _order is now 'event_id, sequence, name, id' ('id') | ||
event / event.event.ticket / color (char) : NEW hasdefault: default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was the colors handled previously? All the tickets with the same color are OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before there was no color, and now it is not used anywhere except in the event form view to define the tickets (i have not seen it used elsewhere). Also, defining random colors I don't think was a good decision either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How this works if you create the same tickets in this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration to 17.0
Depends on:
utm
: [17.0][OU-ADD] utm: Nothing to do #4664@Tecnativa TT49909