Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][OU-ADD] event: Migration scripts #4663

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Nov 14, 2024

Migration to 17.0

Depends on:

@Tecnativa TT49909

@legalsylvain
Copy link
Contributor

legalsylvain commented Nov 14, 2024

/ocabot migration event

@victoralmau
Copy link
Member Author

I am not sure if the analysis is up to date, I just saw that (for example) the seats_expected field does not exist in v17.
Can you update the analysis?

Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiquelRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-4663-by-MiquelRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ae606a8 into OCA:17.0 Dec 31, 2024
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ae606a8. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-event branch December 31, 2024 16:40
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victoralmau please fix my comments in an extra PR.

@MiquelRForgeFlow it's convenient to not merge this so lightly.

event / event.event / registration_properties_definition (properties_definition): NEW
# NOTHING TO DO
event / event.event.ticket / _order : _order is now 'event_id, sequence, name, id' ('id')
event / event.event.ticket / color (char) : NEW hasdefault: default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was the colors handled previously? All the tickets with the same color are OK?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before there was no color, and now it is not used anywhere except in the event form view to define the tickets (i have not seen it used elsewhere). Also, defining random colors I don't think was a good decision either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How this works if you create the same tickets in this version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is only used in the form view of the event.
test

Is it a problem that old tickets have the same color defined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants