[17.0][OU-ADD] mail: migration to 17.0 #4431

duong77476-viindoo · 2024-05-22T04:49:27Z

No description provided.

pedrobaeza · 2024-05-25T16:01:45Z

/ocabot migration mail

flachica · 2024-06-27T09:30:51Z

I need to send suggestion to this PR. I need remove some views. What is the best way to send it?. I need to test previously in my own branch. This is the reason because I send PR to this branch

duong77476-viindoo · 2024-06-27T09:34:30Z

I need to send suggestion to this PR. I need remove some views. What is the best way to send it?. I need to test previously in my own branch. This is the reason because I send PR to this branch

Which view you want to remove and why?
You can go to files changed and leave some reviews there, first time on github ?

pedrobaeza · 2024-06-27T09:37:07Z

No, views are never needed to be removed manually in OU.

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt

flachica · 2024-06-27T09:43:36Z

No, views are never needed to be removed manually in OU.

The mail.mail_channel_view_kanban view have an element with attrs attribute that is forbbiden in 17.0. What is the correct way to solve this without remove it manually . . .if exists?

pedrobaeza · 2024-06-27T09:48:13Z

Check my comment at #4431 (comment)

If that doesn't happen, then the patch is not correctly done (or should be expanded) at openupgrade_framework level.

hbrunn · 2024-10-14T08:06:42Z

openupgrade_scripts/scripts/mail/17.0.1.15/post-migration.py

+
+    domain = icp.get_param("mail.catchall.domain")
+    if domain:
+        alias_domain_id = openupgrade.logged_query(


this is not how logged_query works, as it returns cr.rowcount - though it will work accidentally here because the table is empty and we insert one record, so the created id is 1 and the count of inserted rows is 1 too.

So please fetch the result anyways to be sure this won't blow up when the table is nonempty for whatever reason.

Sorry my bad. but this pr is no longer my burden to bear , at least until next year. You can continue my work if you want. Thanks

hbrunn · 2024-10-14T08:42:14Z

openupgrade_scripts/scripts/mail/17.0.1.15/post-migration.py

+    if company.alias_domain_id:
+        openupgrade.logged_query(
+            env.cr,
+            f"""


why don't you just join with mail_alias_domain here unconditionally, given mail_alias_domain is filled above?

hbrunn · 2024-10-14T09:13:14Z

openupgrade_scripts/scripts/mail/17.0.1.15/pre-migration.py

+        SET alias_incoming_local = True
+        """,
+    )
+    openupgrade.logged_query(
+        env.cr,
+        """
+        UPDATE mail_alias
+        SET alias_status = 'not_tested'


why not one query?

Further, I think we should assume that we get a correctly configured database and we migrate correct configurations correctly, so the alias status should be valid in my opinion.

pedrobaeza · 2024-10-14T09:36:09Z

I will resume the work this week.

remi-filament

Thanks @duong77476-viindoo for the time you spent on that one
I have completed my review if that can help on your work of takeover of this PR @pedrobaeza

remi-filament · 2024-10-18T12:19:39Z

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt

+mail         / mail.gateway.allowed     / email (char)                  : now required
+# DONE pre-migration: fill dummy value if Null found


I cannot find where this is filled in pre-migration ? I suppose we should leave it empty to be filled manually by an admin after migration.

remi-filament · 2024-10-18T12:20:19Z

openupgrade_scripts/scripts/mail/17.0.1.15/pre-migration.py

+        "discuss.channel",
+        "discuss_channel",


Should be

Suggested change

"discuss.channel",

"discuss_channel",

"mail.tracking.value",

"mail_tracking_value",

remi-filament · 2024-10-18T12:27:13Z

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt

+
+mail         / mail.template            / report_template (many2one)    : DEL relation: ir.actions.report
+mail         / mail.template            / report_template_ids (many2many): NEW relation: ir.actions.report
+# DONE pre-migraton: m2o to m2m


Suggested change

# DONE pre-migraton: m2o to m2m

# DONE post-migraton: m2o to m2m

Also, in pre-migration, you should probably copy the column so that it is not dropped during upgrade (as stated here : https://oca.github.io/openupgradelib/API.html#openupgradelib.openupgrade.m2o_to_x2m)

remi-filament · 2024-10-18T12:41:05Z

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt

+
+mail         / mail.tracking.value      / new_value_monetary (float)    : DEL
+mail         / mail.tracking.value      / old_value_monetary (float)    : DEL
+# TODO pre-migration: fill value into old/new_value_float


Suggested change

# TODO pre-migration: fill value into old/new_value_float

# DONE: pre-migration: fill value into old/new_value_float

remi-filament · 2024-10-18T12:42:17Z

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt

+mail         / res.users.settings       / _order                        : module is now 'base' ('mail')
+mail         / res.users.settings       / display_name (char)           : module is now 'base' ('mail')
+mail         / res.users.settings       / user_id (many2one)            : module is now 'base' ('mail')
+# NOTHING TODO


Suggested change

# NOTHING TODO

# NOTHING TO DO: done in base migration scripts

remi-filament · 2024-10-18T12:56:37Z

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt

+DEL ir.model.constraint: mail.constraint_bus_presence_partner_or_guest_exists
+DEL ir.model.constraint: mail.constraint_mail_activity_check_res_id_is_set
+DEL ir.model.constraint: mail.constraint_mail_alias_alias_unique
+DEL ir.model.constraint: mail.constraint_mail_blacklist_unique_email
+DEL ir.model.constraint: mail.constraint_mail_channel_channel_type_not_null
+DEL ir.model.constraint: mail.constraint_mail_channel_group_public_id_check
+DEL ir.model.constraint: mail.constraint_mail_channel_member_partner_or_guest_exists
+DEL ir.model.constraint: mail.constraint_mail_channel_rtc_session_channel_member_unique
+DEL ir.model.constraint: mail.constraint_mail_channel_uuid_unique
+DEL ir.model.constraint: mail.constraint_mail_followers_mail_followers_res_partner_res_model_id_uniq
+DEL ir.model.constraint: mail.constraint_mail_message_reaction_partner_or_guest_exists
+DEL ir.model.constraint: mail.constraint_mail_notification_notification_partner_required
+DEL ir.model.constraint: mail.constraint_res_users_notification_type
+DEL ir.model.constraint: mail.constraint_res_users_settings_unique_user_id [renamed to base module]
+DEL ir.model.constraint: mail.constraint_res_users_settings_volumes_partner_or_guest_exists


I am not sure where this list of constraints come from (I do not have the same list in upgrade_analysis.txt) and most of the ones listed here still exist, or have corresponding ones on renamed models.

From my point of view you should have :

NEW ir.model.constraint: mail.constraint_discuss_channel_channel_type_not_null DEL ir.model.constraint: mail.constraint_mail_channel_channel_type_not_null NEW ir.model.constraint: mail.constraint_discuss_channel_group_public_id_check DEL ir.model.constraint: mail.constraint_mail_channel_group_public_id_check NEW ir.model.constraint: mail.constraint_discuss_channel_member_partner_or_guest_exists DEL ir.model.constraint: mail.constraint_mail_channel_member_partner_or_guest_exists NEW ir.model.constraint: mail.constraint_discuss_channel_rtc_session_channel_member_unique DEL ir.model.constraint: mail.constraint_mail_channel_rtc_session_channel_member_unique NEW ir.model.constraint: mail.constraint_discuss_channel_uuid_unique DEL ir.model.constraint: mail.constraint_mail_channel_uuid_unique # NOTHING TO DO: handled by model rename from pre-commit NEW ir.model.constraint: mail.constraint_discuss_gif_favorite_user_gif_favorite NEW ir.model.constraint: mail.constraint_mail_alias_domain_bounce_email_uniques NEW ir.model.constraint: mail.constraint_mail_alias_domain_catchall_email_uniques NEW ir.model.constraint: mail.constraint_mail_partner_device_endpoint_unique # NOTHING TO DO: will be created by ORM DEL ir.model.constraint: mail.constraint_mail_alias_alias_unique # TODO: this one needs to be safely removed in post-migration using openupgrade.delete_sql_constraint_safely DEL ir.model.constraint: mail.constraint_res_users_settings_unique_user_id [renamed to base module] # NOTHING TO DO: done in base module

remi-filament · 2024-10-18T12:58:17Z

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt

+DEL ir.rule: mail.ir_rule_mail_channel_member_group_user (noupdate)
+DEL ir.rule: mail.mail_channel_admin (noupdate)
+DEL ir.rule: mail.mail_channel_rule (noupdate)
+# NOTHING TO DO: removed in post-migration


Suggested change

# NOTHING TO DO: removed in post-migration

# DONE: post-migration: safe removal

remi-filament · 2024-10-18T12:59:28Z

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt

+
+DEL mail.channel: mail.channel_all_employees (noupdate)
+DEL mail.channel.member: mail.channel_member_general_channel_for_admin (noupdate)
+# NOTHING TO DO: removed in post-migration


Suggested change

# NOTHING TO DO: removed in post-migration

# DONE: post-migration: safe removal

remi-filament · 2024-10-18T13:11:55Z

openupgrade_scripts/scripts/mail/17.0.1.15/pre-migration.py

+_tables_renames = [
+    ("mail_channel", "discuss_channel"),
+    ("mail_channel_member", "discuss_channel_member"),
+    ("mail_channel_rtc_session", "discuss_channel_rtc_session"),
+]


You should also rename mail_channel_res_groups_rel table to discuss_channel_res_groups_rel

And column mail_channel_id to discuss_channel_id in that table.

rvalyi · 2024-10-18T14:42:47Z

Hello, as usual, odoo-module-diff may help you write or check the scripts. Here are 14 key commits for the the mail migration to v17: https://github.com/akretion/odoo-module-diff-analysis/tree/main/17.0/mail

hbrunn · 2024-10-21T16:02:26Z

superseded by #4600

@remi-filament thank for your very thorough review, I took nearly all of your comments and add comments on the new PR where I deviated

duong77476-viindoo mentioned this pull request May 22, 2024

[MIG] openupgrade_framework v17 #4427

Merged

2 tasks

duong77476-viindoo force-pushed the v17_ou_add_mail branch from 805a748 to cd8ea66 Compare May 25, 2024 03:41

OCA-git-bot added this to the 17.0 milestone May 25, 2024

OCA-git-bot mentioned this pull request May 25, 2024

Migration to version 17.0 #4124

Open

81 tasks

pedrobaeza changed the title ~~[OU-ADD] mail: migration to 17.0~~ [17.0][OU-ADD] mail: migration to 17.0 May 25, 2024

[OU-ADD] mail: migration to 17.0

9ed931f

duong77476-viindoo force-pushed the v17_ou_add_mail branch from cd8ea66 to 9ed931f Compare June 12, 2024 07:06

flachica reviewed Jun 27, 2024

View reviewed changes

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt Show resolved Hide resolved

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt Show resolved Hide resolved

openupgrade_scripts/scripts/mail/17.0.1.15/upgrade_analysis_work.txt Show resolved Hide resolved

hbrunn requested changes Oct 14, 2024

View reviewed changes

remi-filament suggested changes Oct 18, 2024

View reviewed changes

remi-filament reviewed Oct 18, 2024

View reviewed changes

hbrunn mentioned this pull request Oct 21, 2024

[17.0][OU-ADD] mail: migration to 17.0 #4600

Merged

hbrunn closed this Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][OU-ADD] mail: migration to 17.0 #4431

[17.0][OU-ADD] mail: migration to 17.0 #4431

duong77476-viindoo commented May 22, 2024

pedrobaeza commented May 25, 2024

flachica commented Jun 27, 2024

duong77476-viindoo commented Jun 27, 2024

pedrobaeza commented Jun 27, 2024

flachica commented Jun 27, 2024

pedrobaeza commented Jun 27, 2024 •

edited

Loading

hbrunn Oct 14, 2024

duong77476-viindoo Oct 14, 2024

hbrunn Oct 14, 2024

hbrunn Oct 14, 2024

pedrobaeza commented Oct 14, 2024

remi-filament left a comment

remi-filament Oct 18, 2024

remi-filament Oct 18, 2024

remi-filament Oct 18, 2024

remi-filament Oct 18, 2024

remi-filament Oct 18, 2024

remi-filament Oct 18, 2024

remi-filament Oct 18, 2024

remi-filament Oct 18, 2024

remi-filament Oct 18, 2024

rvalyi commented Oct 18, 2024

hbrunn commented Oct 21, 2024

		mail / mail.gateway.allowed / email (char) : now required
		# DONE pre-migration: fill dummy value if Null found

	# DONE pre-migraton: m2o to m2m
	# DONE post-migraton: m2o to m2m

	# TODO pre-migration: fill value into old/new_value_float
	# DONE: pre-migration: fill value into old/new_value_float

	# NOTHING TODO
	# NOTHING TO DO: done in base migration scripts

	# NOTHING TO DO: removed in post-migration
	# DONE: post-migration: safe removal

[17.0][OU-ADD] mail: migration to 17.0 #4431

[17.0][OU-ADD] mail: migration to 17.0 #4431

Conversation

duong77476-viindoo commented May 22, 2024

pedrobaeza commented May 25, 2024

flachica commented Jun 27, 2024

duong77476-viindoo commented Jun 27, 2024

pedrobaeza commented Jun 27, 2024

flachica commented Jun 27, 2024

pedrobaeza commented Jun 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 14, 2024

remi-filament left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rvalyi commented Oct 18, 2024

hbrunn commented Oct 21, 2024

pedrobaeza commented Jun 27, 2024 •

edited

Loading