Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][OU-FIX] Base: Add help in ir.actions.client translation exclusions #4254

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[16.0][OU-FIX] Base: Add help in ir.actions.client translation exclusions #4254

merged 1 commit into from
Dec 14, 2023

Conversation

cvinh
Copy link
Contributor

@cvinh cvinh commented Dec 14, 2023 

In PR https://github.com/OCA/OpenUpgrade/pull/3866, cyrilmanuel <[email protected]>
fixed the same issue for ir.actions.act_window translation

The pre-migration script excludes some fields from models, inherited by ir.actions fields.
The goal is to allow the conversion of all text fields in json or jsonb (mecanic in odoo 16),
but if the field is inherited by another fields in another model (in my example, name and help
in the model ir_actions_client are inherited by ir.actions fields), you cannot execute the sql request.
It will failed because you cannot convert fields inherited.

@cvinh
[OU-FIX] Base: Add help in ir.actions.client translation exclusions
d8b8b3f 
    In commit d2659fb, cyrilmanuel <[email protected]>
    fixed the same issue for ir.actions.act_window translation

    The pre-migration script excludes some fields from models, inherited by ir.actions fields.
    The goal is to allow the conversion of all text fields in json or jsonb (mecanic in odoo 16),
    but if the field is inherited by another fields in another model (in my example, name and help
    in the model ir_actions_client are inherited by ir.actions fields), you cannot execute the sql request.
    It will failed because you cannot convert fields inherited.
@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 14, 2023
@pedrobaeza pedrobaeza merged commit c0aa082 into OCA:16.0 Dec 14, 2023
2 checks passed
@huguesdk huguesdk mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cvinh @pedrobaeza