-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][OU-ADD] stock_picking_responsible: merged into stock #4238
[13.0][OU-ADD] stock_picking_responsible: merged into stock #4238
Conversation
0936711
to
6b00e4a
Compare
We copy the legacy column to convert data in post-migration script. | ||
""" | ||
if openupgrade.column_exists(env.cr, "stock_picking", "responsible_id"): | ||
openupgrade.copy_columns( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to copy or rename the column. It's going to be there in post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it as you suggested, should we just leave the responsible_id
in the database ?
) | ||
partner_wo_user = env.cr.fetchall() | ||
for picking_id, picking_name, partner_id, partner_name in partner_wo_user: | ||
_logger.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, what about creating a disabled user and fill it with it?
bbbb2e8
to
4f00042
Compare
4f00042
to
8d44dea
Compare
Here you go Pedro, thank you for the review and suggestions :-) |
responsible_id field in
stock_picking_responsible
is replaced by user_id instock
. The script migrates data fromto
First PR on OpenUpgrade, comments welcome.