Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0[OU-ADD] project: migration data #3989

Closed
wants to merge 50 commits into from

Conversation

SonCrits
Copy link
Contributor

@SonCrits SonCrits commented Jul 3, 2023

Migration data

@legalsylvain
Copy link
Contributor

legalsylvain commented Jul 3, 2023

/ocabot migration project

@SonCrits SonCrits force-pushed the v16_add_project_1 branch 2 times, most recently from 4884dce to a1b0788 Compare July 17, 2023 07:46
@legalsylvain
Copy link
Contributor

Hi @SonCrits. There is a conflict, and unrelated commits. Could you rebase ?
thanks !

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from the need for rebase @legalsylvain asked, I also see that you defined a _fill_proejct_allow_milestones(yes with the typo) and you didn't call it anywhere.
I believe it should be called to fill the new allow_milestones field.

@legalsylvain
Copy link
Contributor

Hi @SonCrits.
Do you think you'll finish this work ?

thanks !

@SonCrits
Copy link
Contributor Author

Hi @SonCrits. Do you think you'll finish this work ?

thanks !

i'm sorry

@SonCrits SonCrits closed this Jan 17, 2024
@remytms
Copy link
Contributor

remytms commented Jan 19, 2024

If I understand, this PR is abandoned. I will take it back. :)

@remytms
Copy link
Contributor

remytms commented Feb 7, 2024

Replaced by #4289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.