[16.0][MIG] base_address_extended #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration base_address_extended |
pedrobaeza
requested changes
Mar 24, 2023
marielejeune
force-pushed
the
16.0-base_address_extended-mle
branch
from
1c0c108
to
ebbd677
Compare
marielejeune
force-pushed
the
16.0-base_address_extended-mle
branch
from
ebbd677
to
10b8463
Compare
pedrobaeza
reviewed
Mar 28, 2023
| @@ -70,7 +70,7 @@ Module coverage 15.0 -> 16.0 | |||
| +-------------------------------------------------+----------------------+-------------------------------------------------+ | |||
| | |del| base_address_city | | | | |||
There was a problem hiding this comment.
Suggested change
| | |del| base_address_city | | | | |
| | |del| base_address_city | Done | Merged into base_address_extended | |
As this has been already tackled in https://github.com/OCA/OpenUpgrade/blob/2d7f8de7289fdf36e0ac48f41ee52b6138190399/openupgrade_scripts/apriori.py#LL34C1-L34C1
openupgrade_scripts/scripts/base_address_extended/16.0.1.1/upgrade_analysis_work.txt
Show resolved
Hide resolved
hbrunn
approved these changes
May 16, 2023
pedrobaeza
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
base_address_citywas merged intobase_address_extended. Is there something else to do than renaming the xmlids?Edit: the modules will be merged with pre-migration script of
base, as they are listed inapriori.py