-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] fetch openupgrade 10.0 docs too #1125
Conversation
the script pulls the default branch btw, should we change the default to 11 by now? |
Yes, let's change the default branch at this stage. Should we freeze the branch to be cloned on the scripts for avoiding errors on new releases until it's manually fixed? |
better not, then we don't notice the errors. Note that building the docs is part of the tests |
Default branch changed. Waiting for Travis result for merging. |
the error here is what we want, this turns green when OCA/openupgradelib#83 is merged |
restarted build after @pedrobaeza merged the PR in openupgradelib |
Restarting Travis now that the other PR has been merged. |
hahaha, we are both the quickest gunman on this side of Odoo |
Can you squash both commits? |
scripts/build_openupgrade_docs
Outdated
@@ -6,7 +6,8 @@ DOC_PARTS="7.0/openerp/openupgrade/doc/source/modules50-60.rst | |||
7.0/openerp/openupgrade/doc/source/modules60-61.rst | |||
7.0/openerp/openupgrade/doc/source/modules61-70.rst | |||
8.0/openerp/openupgrade/doc/source/modules70-80.rst | |||
9.0/openerp/openupgrade/doc/source/modules80-90.rst" | |||
9.0/openerp/openupgrade/doc/source/modules80-90.rst | |||
10.0/odoo/openupgrade/doc/source/modules90-100.rst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put the quote in other line for avoiding 2 lines diff on each version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think optimistic ;-) The optimistic way is to merge and then create a new PR yourself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't know very well this part. That's why I'm asking if it can be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
1e164b7
to
79e0579
Compare
I think it would be conceptually wrong to squash those two commits as they do very different things |
Thanks, merging then with 2 commits. |
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr