[FIX] hr_fleet: add pre-migration to create value for compute field with

store=true by sql instead of auto orm
OCA · Jul 21, 2023 · bf17251 · bf17251
1 parent 1b32e71
commit bf17251
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 2 deletions.
diff --git a/docsource/modules150-160.rst b/docsource/modules150-160.rst
@@ -172,7 +172,7 @@ Module coverage 15.0 -> 16.0
 +-------------------------------------------------+----------------------+-------------------------------------------------+
 | hr_expense                                      |                      |                                                 |
 +-------------------------------------------------+----------------------+-------------------------------------------------+
-| hr_fleet                                        | Nothing to do        |                                                 |
+| hr_fleet                                        | Done                 |                                                 |
 +-------------------------------------------------+----------------------+-------------------------------------------------+
 | hr_gamification                                 |                      |No DB layout changes.                            |
 +-------------------------------------------------+----------------------+-------------------------------------------------+

diff --git a/openupgrade_scripts/scripts/hr_fleet/16.0.1.0/pre-migration.py b/openupgrade_scripts/scripts/hr_fleet/16.0.1.0/pre-migration.py
@@ -0,0 +1,26 @@
+from openupgradelib import openupgrade
+
+
+def create_drive_employee(env):
+    openupgrade.logged_query(
+        env.cr,
+        """
+        ALTER TABLE fleet_vehicle_assignation_log
+        ADD IF NOT EXISTS driver_employee_id INT
+        """,
+    )
+
+    openupgrade.logged_query(
+        env.cr,
+        """
+        UPDATE fleet_vehicle_assignation_log AS fval
+        SET driver_employee_id = fv.driver_employee_id
+        FROM fleet_vehicle AS fv
+        WHERE fval.vehicle_id = fv.id
+        """,
+    )
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    create_drive_employee(env)
diff --git a/openupgrade_scripts/scripts/hr_fleet/16.0.1.0/upgrade_analysis_work.txt b/openupgrade_scripts/scripts/hr_fleet/16.0.1.0/upgrade_analysis_work.txt
@@ -3,7 +3,7 @@
 hr_fleet     / fleet.vehicle.assignation.log / driver_employee_id (many2one) : is now stored
 hr_fleet     / fleet.vehicle.assignation.log / driver_employee_id (many2one) : not related anymore
 
-# NOTHING TO DO: field changed from related field to compute field
+# DONE: fill data from old related field for now store current compute field in pre-migration
 
 ---XML records in module 'hr_fleet'---
 NEW ir.ui.view: hr_fleet.fleet_vehicle_assignation_log_employee_view_list