Skip to content

Update information on VariO #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 29, 2023
Merged

Update information on VariO #2103

merged 24 commits into from
May 29, 2023

Conversation

cthoyt
Copy link
Collaborator

@cthoyt cthoyt commented Sep 27, 2022

This PR does the following:

  1. Add the ORCID and email given by @maunov in New version of VariO #2090 (comment)
  2. Adds the CC BY 4.0 license as given by @maunov in New version of VariO #2090 (comment)
  3. Removes the redundant body text as the short description.
  4. Adds the 3 publications listed on the VariO homepage
  5. Add missing domain annotation
  6. Switches VariO's activity status from "orphaned" to "inactive" and annotates a to-do list for how to proceed

@matentzn
Copy link
Contributor

Ok will wait for confirmation

@cthoyt cthoyt changed the title Add more contact information to VariO Update information on VariO Sep 27, 2022
@cthoyt
Copy link
Collaborator Author

cthoyt commented Oct 1, 2022

@matentzn is there official policy on whether a public issue tracker is required?

@matentzn
Copy link
Contributor

matentzn commented Oct 1, 2022

@matentzn is there official policy on whether a public issue tracker is required?

100%, see https://obofoundry.org/principles/fp-020-responsiveness.html A discussion mailing list and issue tracker are required to obtain an OBO Foundry PURL. The discussion mailing list requirement should probably be removed.

@matentzn
Copy link
Contributor

@maunov please confirm that the information in this PR is all accurate.

@maunov
Copy link

maunov commented Oct 24, 2022

Thanks, The details seem to be correct.
We will fix the issues with tracker and PURL redirects.
Have to see how to make the tracker to work.

All the best,

Mauno

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There must be a public issue tracker

@matentzn
Copy link
Contributor

@maunov could you check this PR please?

@cthoyt
Copy link
Collaborator Author

cthoyt commented Nov 15, 2022

@maunov could you check this PR please?

He already checked and approved in #2103 (comment), we haven't made any changes since beside discussion - you might want to ping him specifically in the threads if you want him to check them

@matentzn matentzn added the awaiting external review Tag to denote that an issue or PR need input from a person external to the OFOC label Nov 15, 2022
@matentzn
Copy link
Contributor

@maunov sorry, to be clear, there are some issue with the PR which need to be sorted out, could you comment on the various open threads please?

@matentzn
Copy link
Contributor

matentzn commented Dec 8, 2022

Ping @maunov

@deepakunni3
Copy link
Member

@maunov It would be great to get your inputs on the conversation threads above.

To summarize:

  • vario.owl: One of the products of VariO is 'VariO in OWL Functional notation' but this is not inline with OBO Principles, as @matentzn pointed out. Could you change this on your end? Or provide an OWL version of the ontology with RDF/XML syntax?
  • vario.owx: OWX format is for OWL/XML whereas RDF/XML is what is recommended and required to satisfy 'Principle 2: Common Format' of the OBO Principles
  • Requirements to become active: In this PR we have 'Requirements to become "active"' directly in the markdown which would be useful for you and your team to know what additional work needs to be done for your ontology (thanks to @cthoyt). If you would like to remove it from vario.md then please let us know your plans towards the listed requirements. (for example, creating tickets on VariO issue tracker to keep track of the requirements)

@cthoyt
Copy link
Collaborator Author

cthoyt commented Feb 26, 2023

@deepakunni3 @matentzn I think we should accept the changes in this PR and leave this ontology marked as orphaned, since we've been relatively unsuccessful at contacting @maunov. I moved the todo list into the title of this PR for later reference.

@matentzn
Copy link
Contributor

I think the contact is not very active on GitHub, I emailed them once more now. I don't want to merge this PR as is as it partially violates the OBO Principles

This was referenced Mar 7, 2023
@deepakunni3
Copy link
Member

@matentzn Did you get a response from @maunov ?

@matentzn
Copy link
Contributor

I sent another follow up and cced you in!

@cthoyt
Copy link
Collaborator Author

cthoyt commented May 25, 2023

@matentzn @deepakunni3 we're well past the suggested window from https://obofoundry.org/docs/SOP.html#META - I think we should take executive action and denote this ontology as either orphaned or inactive, then call it done

@deepakunni3
Copy link
Member

Thank you @cthoyt for bringing this up.

Yes, it has been 2 months our email to @maunov .

@matentzn What do you recommend here? Should we mark the ontology as inactive/orphaned or just accept the changes in this PR as-is and merge?

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed two entries that are just confusing, can be merged @deepakunni3

  • The contact info is just augmented information, which is already public, so no concern
  • the license has been confirmed here

@deepakunni3
Copy link
Member

Thanks @matentzn

@deepakunni3 deepakunni3 merged commit d2ac5a8 into OBOFoundry:master May 29, 2023
@cthoyt cthoyt deleted the patch-4 branch May 30, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting external review Tag to denote that an issue or PR need input from a person external to the OFOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants