Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial version of the mineflayer based npm test #348

Merged
merged 3 commits into from
Apr 24, 2022

Conversation

edewit
Copy link
Member

@edewit edewit commented Apr 9, 2022

$> cd test-utils/mineflayer
$> gradle test

This test will fail atm because the server isn't in offline mode
and the Player that mineflayer uses doesn't have rights to execute /make

Once these 2 things are fixed this test will pass

test-utils/mineflayer/settings.gradle Outdated Show resolved Hide resolved
test-utils/mineflayer/storeys.test.js Outdated Show resolved Hide resolved
test-utils/mineflayer/build.gradle Outdated Show resolved Hide resolved
@vorburger
Copy link
Member

This test will fail atm because the server isn't in offline mode

We COULD change ENV SKIP_SERVER_PROPERTIES from true to false in both Dockerfile and Dockerfile-local AND ENV ONLINE_MODE=FALSE BUT then we'll loose being in creative, because of itzg/docker-minecraft-server#1452. I can't quite think of a "workaround". Unless @edewit you can think of something, i think we have 2 obvious choice here: (a) switch it in our server.properties #L43 (in minecraft-server/ NOT in minecraft-server-test-data), (b) wait for @itzg to release a new image. For me we can do (a) for now, and "later" revert and (b). Unless @itzg jump on this with this incredible support and wants to make a new release in the next few days?

and the Player that mineflayer uses doesn't have rights to execute /make

I'm torn how to best go about this. It seems like a shame to give up on the permission check for /make. But even if we had #276 for LuckPerms (I could priorititze working on that next), I don't know how we would "grant the anonymous Mineflyer user the permission to /make. Hm.

@itzg
Copy link

itzg commented Apr 11, 2022

I had gotten myself confused and thought I was caught up on releases 😃 There is now a new release with the changes: https://github.com/itzg/docker-minecraft-server/releases/tag/2022.6.0

@edewit
Copy link
Member Author

edewit commented Apr 12, 2022

Wauw @itzg has our back, so we can do (b)

edewit and others added 3 commits April 24, 2022 20:11
incl. adding ONLINE_MODE=FALSE to ./test, as well as
removing OPS (as it doesn't seem to work with ONLINE_MODE=FALSE anymore, surprisingly);
the idea is to fix this with LuckPerms configuration later.
The idea is to un-comment it later by making Mineflayer use a
UID which has this permission through LuckPerms configuration.
@vorburger vorburger merged commit 374e751 into OASIS-learn-study:develop Apr 24, 2022
@edewit edewit deleted the mineflayer branch April 24, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants