Skip to content

Revive .dockerignore #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2021
Merged

Revive .dockerignore #271

merged 2 commits into from
Oct 30, 2021

Conversation

vorburger
Copy link
Member

@vorburger
Revert "rm .dockerignore (OASIS-learn-study#262)"
a4f40ab 
This reverts commit ffc2b86.
@vorburger
add Dockerfile itself to .dockerignore
934b76e 
This makes changes to the Dockerfile not
to cause a full rebuild, which it does without this,
because of the COPY . /project.
@vorburger vorburger mentioned this pull request Oct 29, 2021
Closed
edewit
edewit approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@edewit edewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay 2 gig is a lot had my whole disk full trying to build... so let's give this a go

@edewit edewit merged commit 20152fb into OASIS-learn-study:develop Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edewit edewit edewit approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vorburger @edewit