Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep CompleteMultipartUpload alive #141

Merged
merged 9 commits into from
May 31, 2024

Conversation

lperlaki
Copy link
Contributor

reopen of #31

changes the response body from the CompleteMultipartUpload Operation to a custom KeepAliveBody that sends a whitespace every 100 milliseconds to keep the request alive

but now with hyper support for trailers

fixes #30


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Nugine
Copy link
Owner

Nugine commented Mar 18, 2024

We have a new failure in e2e tests. Maybe a compatibility issue?

{
  "name": "aws-sdk-php",
  "function": "uploadPart ( array $params = [] )",
  "args": {
    "Bucket": "aws-sdk-php-65f762b387bb0",
    "Object": "obj1"
  },
  "duration": "261",
  "status": "FAIL",
  "error": "Your proposed upload is smaller than the minimum allowed object size."
}

crates/s3s/src/ops/mod.rs Outdated Show resolved Hide resolved
@Nugine Nugine self-assigned this Apr 2, 2024
@Nugine
Copy link
Owner

Nugine commented Apr 17, 2024

I'm busy for the next three weeks. I'll look into the e2e test failure after that. Sorry about the delay but finally we will complete.

@Nugine
Copy link
Owner

Nugine commented May 31, 2024

It seems that we hit a bug in aws-sdk-php.

I'll allow the failed test and merge this PR soon.

@Nugine Nugine enabled auto-merge (squash) May 31, 2024 17:10
@Nugine Nugine merged commit dda3c09 into Nugine:main May 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout with CompleteMultipartUpload
2 participants