Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make license text part of sidebar license link #10246

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Goodyear2017
Copy link
Contributor

@Goodyear2017 Goodyear2017 commented Nov 4, 2024

1.Accessibility Issue:
AI4W reported packages page sidebar link "MIT" and surrounding text "license" having issue.
image
2. Fixed the issue by removing "license" text into the link.
3. Result:
image
image

Bug URL:
#10247

@Goodyear2017 Goodyear2017 requested a review from a team as a code owner November 4, 2024 18:57
@erdembayar
Copy link
Contributor

@Goodyear2017
Please add any related issue link in description.

@Goodyear2017
Copy link
Contributor Author

@Goodyear2017 Please add any related issue link in description.
I just created a bug for this issue:
#10247

@mariaghiondea mariaghiondea requested a review from ryuyu November 5, 2024 18:41
@agr
Copy link
Contributor

agr commented Nov 5, 2024

Unclear why only the license link was flagged. The download links directly below are doing the same (have text that is not a link right after the link):

image

Should those be fixed as well?

@ryuyu
Copy link
Contributor

ryuyu commented Nov 5, 2024

Unclear why only the license link was flagged. The download links directly below are doing the same (have text that is not a link right after the link):

image

Should those be fixed as well?

I think the existence of the parenthesis qualifies it as more than text colour differentiation, and thus this one isn't an issue? Maybe?
In any case, it doesn't seem to get flagged by tools or Accessibility team.

@erdembayar
Copy link
Contributor

I'll merge tomorrow or the day after tomorrow. Let's wait if there are any more reviews.

Happy coding! 🧑‍💻

@erdembayar erdembayar merged commit 7316c09 into NuGet:dev Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants