Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Better support for MMC3_198 #33

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Better support for MMC3_198 #33

merged 1 commit into from
Jun 22, 2021

Conversation

RokkumanX
Copy link

Courtesy to @Rabenda

I took the liberty of polishing and tidying up the comments, otherwise it should work as intended.

Courtesy to @Rabenda

I took the liberty of polishing and tidying up the comments, otherwise it should work as intended.
@NovaSquirrel NovaSquirrel merged commit 82e6ff0 into NovaSquirrel:master Jun 22, 2021
@RokkumanX RokkumanX deleted the patch-1 branch June 22, 2021 17:56
@RevySR
Copy link

RevySR commented Jun 23, 2021

SourMesen#555 (comment)

Actually the comment is right. The ROM is mapper224.
But some nes which is mapper198 is masked wrongly.

@RokkumanX
Copy link
Author

Thanks for the input @Rabenda !

So is there something wrong in the commit that needs to be changed or fixed?

A little backstory to all this would be that your pull request in the main Mesen repository came to my attention and I thought that it probably will be forever opened so I decided that I wanted to incorporate it in my own repository and here since this is the most up to date fork of Mesen.

I did a little research on it and thought it would be good to have so I made this.

Feel free to comment on this, because if there is something wrong I would like to know.

@caiqijie0
Copy link

could you support 2mb for mapper198

@caiqijie0
Copy link

Can you make Mapper 198 support 2MB

@caiqijie0
Copy link

value & 0x7F; value & 0xfF;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants