-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
languages/nix: add nixd to supported LSP servers #458
base: v0.7
Are you sure you want to change the base?
Conversation
64713b0
to
3d1e38c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM.
Left a few comments for consistency, if you could also add an entry to the changelogs this should be good to go.
Almost forgot, please rebase on the |
There is a reaoson we didn't already have nixd, so we should be a little more cautious about merging this. I think some features rely on LSP settings (which the user can't configure until the rewrite). |
Undo change made by nixfmt-rfc-style
I submitted a pr for the rebased commit. Should I close this one considering it may be unecessary? |
You could've just pushed that to this branch, and set the target branch to v0.7 (which I would still prefer to preserve comments). |
Sorry...I'm a little stupid |
Add nixd as a possible lsp for nix.
Sanity Checking
nix fmt
)..#nix
(default package).#maximal
.#docs-html
x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin
Add a 👍 reaction to pull requests you find important.