Fix type spec #83
Merged
Fix type spec #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2024 10:59
The `eredis:q/2` function can return a list of empty lists when
executing a `MULTI` command.
Minimal example to reproduce:
```
> {ok, Client} = eredis:start_link(localhost, 6379, 0, "redis-password").
{ok,<0.2978.0>}
> eredis:q(Client, ["MULTI"]).
{ok,<<"OK">>}
> eredis:q(Client, ["ZRANGE", <<"non-existent-key">>, 0, 0]).
{ok,<<"QUEUED">>}
> eredis:q(Client, ["ZRANGE", <<"non-existent-key">>, -1, -1]).
{ok,<<"QUEUED">>}
> eredis:q(Client, ["EXEC"]).
{ok,[[],[]]}
```
zuiderkwast
reviewed
Aug 16, 2024
doc/eredis.md
Outdated
| @@ -53,7 +53,7 @@ obfuscated() = fun(() -> iodata()) | |||
|
|
|||
|
|
|||
| <pre><code> | |||
| option() = {host, string() | {local, string()}} | {port, <a href="https://www.erlang.org/doc/man/inet.html#type-port_number">inet:port_number()</a>} | {database, integer()} | {username, iodata() | <a href="#type-obfuscated">obfuscated()</a> | undefined} | {password, iodata() | <a href="#type-obfuscated">obfuscated()</a> | undefined} | {reconnect_sleep, <a href="#type-reconnect_sleep">reconnect_sleep()</a>} | {connect_timeout, integer()} | {socket_options, list()} | {tls, [<a href="https://www.erlang.org/doc/man/ssl.html#type-tls_client_option">ssl:tls_client_option()</a>]} | {name, <a href="#type-registered_name">registered_name()</a>} | {sentinel, list()} | |||
| option() = {host, string() | {local, string()}} | {port, <a href="inet.md#type-port_number">inet:port_number()</a>} | {database, integer()} | {username, iodata() | <a href="#type-obfuscated">obfuscated()</a> | undefined} | {password, iodata() | <a href="#type-obfuscated">obfuscated()</a> | undefined} | {reconnect_sleep, <a href="#type-reconnect_sleep">reconnect_sleep()</a>} | {connect_timeout, integer()} | {socket_options, list()} | {tls, [<a href="ssl.md#type-tls_client_option">ssl:tls_client_option()</a>]} | {name, <a href="#type-registered_name">registered_name()</a>} | {sentinel, list()} | |||
There was a problem hiding this comment.
What happened here? These links will not work anymore.
How did you update this file?
There was a problem hiding this comment.
I just ran make edoc as it was instructed in the contributing document. I think I was using and older rebar / Erlang version. I rerun make edoc with rebar 3.23.0 on Erlang/OTP 25 Erts 13.0, it looks okay now.
There was a problem hiding this comment.
Ah, ok.
I guess we need to change something to make it work correctly with newer versions. If you find out how, please let me know.
zuiderkwast
approved these changes
Aug 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eredis:q/2function can return a list of empty lists when executing aMULTIcommand.Minimal example to reproduce: