Fix for issue #54 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @pixalytics! Can you please bump the version number in galaxy-tools/tools/c3s/c3s.xml Line 1 in 8ee4d5f |
|
@bgruening Thanks for the feedback, I've made that change |
|
The failing tests are linting warnings. Nothing crucial. Lets see what @annefou is saying. |
|
Hi @pixalytics Thank you so much for fixing this long standing bug. I have to admit I forgot about it. This is really super useful contribution! |
|
@annefou Happy to support. We'll be working on developing training material for at least the next few months, so I'll make further suggestions if we find further updates helpful. |
|
Awesome! Thanks a lot @pixalytics! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've started to use the EU Galaxy platform as part of an OGC Open Science Persistent Demonstrator Pilot, and I wanted to use this tool as part of a demonstration workflow. However, what's downloaded within the zip file I'm retrieving from CDS is a NetCDF rather than GRIB file. Looking at the repo issues, I noticed this bug had already been reported under issue #54 So, I'm proposing a fix to that bug.
Best Wishes, Sam