Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Use strncpy to avoid buffer overflow #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lamcodeofpwnosec
Copy link

@lamcodeofpwnosec lamcodeofpwnosec commented Feb 7, 2025

In _imagingcms.c used pillow vulnerable a buffer overflow exists because strcpy is used instead of strncpy.

    else {
        /* take a wild guess... but you probably should fail instead. */
        return TYPE_GRAY_8; /* so there's no buffer overrun... */

POC

https://raw.githubusercontent.com/horizon3ai/CVE-2022-28219/refs/heads/main/CVE-2022-28219.py

CWE-120
CWE-676
CWE-680
CVE-2024-28219

Code changes

Please delete options that are not relevant.

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Vulnerability mitigation update (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new Warnings, errors, bugs
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant