[Feature/#9] : 약속 생성 UI 구현 #33

twogarlic · 2025-01-18T16:29:35Z

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

merge할 브랜치의 위치를 확인해 주세요.(main❌/develop⭕)
리뷰가 필요한 경우 리뷰어를 지정해 주세요.
리뷰는 PR이 올라오면 최대한 빠르게 진행합니다.
P1 단계의 리뷰는 빠르게 확인 후 반영합니다.
Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다.

📌 𝗜𝘀𝘀𝘂𝗲𝘀

closed [UI] : 약속 생성 UI #9

📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

약속 생성으로 이사시켯슴니다
타임피커, 캘린더 수정햇슴니다
코리 반영햇슴니다

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

Screen_recording_20250119_012825.mp4

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

소재고갈이슈

gaeulzzang

AppointmentCreateInfo 에서 텍스트 필드 입력값과 "시간" 텍스트 사이의 간격 다름
AppointmentCreateInfo 에서 약속 이름 텍스트 필드 활성/비활성 컬러값 다름
AppointmentCreatePeriod 에서 "하루씩 설정하기"를 off 했을 때 하루만 선택하더라도 버튼이 활성화되어야 하는데 비활성화 되고 있음
AppointmentCreateTimePicker에서 duration 로직 이슈

해당 이슈 꼭 해결해주시고 까먹지 말고 ./gradlew ktlintCheck 돌려주세요

.../com/sopt/presentation/appointmentCreate/appointmentCreateInfo/AppointmentCreateInfoRoute.kt

gaeulzzang · 2025-01-19T08:04:00Z

.../com/sopt/presentation/appointmentCreate/appointmentCreateInfo/AppointmentCreateInfoRoute.kt

+                TimeTextField(
+                    onValueChange = { newDuration ->
+                        appointmentDuration = newDuration
+                    }
+                )
+                Text(
+                    text = stringResource(R.string.text_calendar_appointment_duration),
+                    style = typography.b1SemiBold,
+                    color = colors.gray700,
+                    modifier = Modifier
+                        .align(Alignment.TopEnd)
+                        .padding(end = 12.dp, top = 15.dp, bottom = 15.dp)
+                )


P1: 텍스트 필드랑 "시간" 텍스트 사이 간격 3.dp여야되는데 지금 너무 멀어요!! TimeTextField 안에서 horizontaldivider 관리하지 말구 밖으로 빼내고 focus 상태 TimeTextField로 전달하는 형식으로 바꿔야될 것 같아요

간격 조절햇서요 horizontaldivider 밖으로 빼면 거리가 또 달라져서 ㅠ.. 안에 냅둬도 댈까요 .. ?ㅠ

.../sopt/presentation/appointmentCreate/appointmentCreatePeriod/AppointmentCreatePeriodRoute.kt

gaeulzzang · 2025-01-19T08:16:12Z

...esentation/appointmentCreate/appointmentCreateTimePicker/AppointmentCreateTimePickerRoute.kt

+                    if (selectedStartHour == selectedEndHour) {
+                        scope.launch {
+                            snackbarHostState.showSnackbar("24시간 이하로 선택해주세요")
+                        }
+                        return@NoostakBottomButton
+                    }


P3: 시작시간과 종료 시간이 같은 경우 토스트 메시지 아직 안나온거죠? ㅠㅠ

ㄴㅖ . . .. . . .. . .. .. .........

...esentation/appointmentCreate/appointmentCreateTimePicker/AppointmentCreateTimePickerRoute.kt

gaeulzzang · 2025-01-19T08:31:26Z

.../main/java/com/sopt/presentation/appointmentCreate/navigation/AppointmentCreateNavigation.kt

+fun NavController.navigateCalendarCheck(
+    appointmentName: String,
+    appointmentCategory: String,
+    appointmentTime: Int,
+    isSingleDateMode: Boolean,
+    appointmentDate: List<String>?,
+    appointmentDuration: String,
+    navOptions: NavOptions? = null
+) {
+    navigate(
+        route = CalendarCheck(
+            appointmentName = appointmentName,
+            appointmentCategory = appointmentCategory,
+            appointmentTime = appointmentTime,
+            isSingleDateMode = isSingleDateMode,
+            appointmentDate = appointmentDate,
+            appointmentDuration = appointmentDuration
+        ),
+        navOptions = navOptions
+    )
+}


P3: 약속 등록 화면으로 넘어가는 로직인걸까요??

네!!! 마자요 !!!!

core/src/main/java/com/sopt/core/designsystem/component/calendar/NoostakCalendar.kt

...esentation/appointmentCreate/appointmentCreateTimePicker/AppointmentCreateTimePickerRoute.kt

presentation/src/main/java/com/sopt/presentation/calendar/CalendarViewModel.kt

youjin09222

수정 사항이 많았는데 고생 많으셨습니다!

core/src/main/java/com/sopt/core/designsystem/component/button/NoostakButton.kt

core/src/main/java/com/sopt/core/designsystem/component/textfield/AppointmentTextField.kt

...esentation/appointmentCreate/appointmentCreateTimePicker/AppointmentCreateTimePickerRoute.kt

.../com/sopt/presentation/appointmentCreate/appointmentCreateInfo/AppointmentCreateInfoRoute.kt

core/src/main/java/com/sopt/core/designsystem/component/checkbox/CircularCheckbox.kt

.../sopt/presentation/appointmentCreate/appointmentCreatePeriod/AppointmentCreatePeriodRoute.kt

...esentation/appointmentCreate/appointmentCreateTimePicker/AppointmentCreateTimePickerRoute.kt

presentation/src/main/java/com/sopt/presentation/calendar/CalendarViewModel.kt

...esentation/appointmentCreate/appointmentCreateTimePicker/AppointmentCreateTimePickerRoute.kt

youjin09222 · 2025-01-20T07:09:34Z

.../main/java/com/sopt/presentation/appointmentCreate/navigation/AppointmentCreateNavigation.kt

+fun NavController.navigateCalendarCheck(
+    appointmentName: String,
+    appointmentCategory: String,
+    appointmentTime: Int,
+    isSingleDateMode: Boolean,
+    appointmentDate: List<String>?,
+    appointmentDuration: String,
+    navOptions: NavOptions? = null
+) {
+    navigate(
+        route = CalendarCheck(
+            appointmentName = appointmentName,
+            appointmentCategory = appointmentCategory,
+            appointmentTime = appointmentTime,
+            isSingleDateMode = isSingleDateMode,
+            appointmentDate = appointmentDate,
+            appointmentDuration = appointmentDuration
+        ),
+        navOptions = navOptions
+    )
+}


P1: composable<"CalendarCheck">가 누락되었습니다! 꼭 추가해주세요!

다른 루트로 대체될 예정이라 해당 코드 삭제하겠습니다

gaeulzzang

까먹을까봐 코멘트 달아둘게요 😪 정보 입력 받는 부분이랑 타임피커 플로우는 더이상 문제 없는 것 같슈...

NoostakCalendar 안에 있는 스낵바 분리하기
스낵바 무조건 bottom(96.dp) 위치에 떠야 하고, 스낵바 컴포넌트화하기
SnackBar는 SideEffect로 두기 -> GroupCreateSuccessRoute 참고
AppointmentCreatePeriod에서 버튼 비활성화 안되는 이슈 해결

Eonji-sw

전.. 하늘언니 pr이 제일 무서워요 ^^
코리 다는데 오백년 걸리거등요 ㅎ.ㅎ
정말 복잡한 로직 수고하셨어요 저라면 탈주했을듯

core/src/main/java/com/sopt/core/designsystem/component/calendar/NoostakCalendar.kt

Eonji-sw · 2025-01-22T10:02:48Z

core/src/main/java/com/sopt/core/designsystem/component/calendar/NoostakCalendar.kt

+                                    .padding(vertical = 11.dp)
+                                    .noRippleClickable {
+                                        if (isSingleDate) {
+                                            if (dateValue in selectedDates) {


P3 : 나중에 더 잘.. 분기처리 리팩할 수 있을 것 같아요 꼭

Eonji-sw · 2025-01-22T10:08:28Z

core/src/main/java/com/sopt/core/designsystem/component/checkbox/CircularCheckbox.kt

P3 : 라디오 버튼도 아니고.. 체크박스인 것이.... 잘 커스텀했네용

core/src/main/java/com/sopt/core/designsystem/component/timepicker/NoostakTimePicker.kt

Eonji-sw · 2025-01-22T10:46:19Z

core/src/main/java/com/sopt/core/designsystem/component/toggle/NoostakSwitch.kt

P2 : toggle 말고 switch로 네이밍 통일하는게 좋을 것 같아요

하면 안된다고 떠서 일단 토글이라고 해놓긴 햇는데 ㅠㅠㅠㅠ 다른 이름 추천해주세여

Eonji-sw · 2025-01-22T10:47:53Z

core/src/main/java/com/sopt/core/designsystem/component/toggle/NoostakSwitch.kt

+    val backgroundColor = if (checked) NoostakTheme.colors.mint else NoostakTheme.colors.gray200
+    val thumbColor = NoostakTheme.colors.white


P2 : 굳이 변수 선언할 필요가 있을까요? 저는 불필요한 메모리 할당이 싫어서 변수는 꼭 필요한 경우에만 선언하는 편이거든요!

gaeulzzang

지이이이인짜 리팩하느라 고생많았다 하늘언니 ㅠㅠㅠㅠㅠㅠ 요청한대로 다 반영해온게 너무 대단한 것 같아... skrrrr
다들 어푸 때리고 얼른 머지하쟈 ❤️😗

twogarlic added 13 commits January 3, 2025 00:29

[UI] 약속 정보, 기간 입력

d35ca17

[REFACTOR] 코드리뷰 반영

184cadd

[REFACTOR] 스트링 추출

8961814

[REFACTOR] ktlint 포맷

06c6252

[REFACTOR] 디벨롭 내용 가져오기

99cff84

[UI] 타임피커

6f5ffe6

[REFACTOR] ktlint 포맷 적용

505b32a

[REFACTOR] 캘린더 수정

75fc39d

[REFACTOR] 코리 반영, 캘린더, 타임피커 임의 수정

5c62998

[REFACTOR] AppointmentCreate로 변경

2b46b79

[MOD] develop 가져오기

de5bfcb

[REFACTOR] 백버튼 추가

e925eb6

[REFACTOR] 수정

daf77f9

twogarlic added 🔨 [FIX] 버그 및 오류 발생 및 해결 ✅ [MOD] 코드 수정 및 내부 파일 수정 ♻️ [REFACTOR] 코드 리팩토링 💟 [UI] UI 작업 ☁️ 하늘 마늘 labels Jan 18, 2025

twogarlic self-assigned this Jan 18, 2025

twogarlic requested a review from a team as a code owner January 18, 2025 16:29

gaeulzzang reviewed Jan 19, 2025

View reviewed changes

...esentation/appointmentCreate/appointmentCreateTimePicker/AppointmentCreateTimePickerRoute.kt Outdated Show resolved Hide resolved

presentation/src/main/java/com/sopt/presentation/calendar/CalendarViewModel.kt Outdated Show resolved Hide resolved

twogarlic and others added 2 commits January 19, 2025 23:00

[REFACOTR] 코리 반영

7afc40f

#9 [ADD] preview 추가

99bd9fc

youjin09222 approved these changes Jan 20, 2025

View reviewed changes

gaeulzzang added 3 commits January 21, 2025 19:54

#9 [REFACTOR] duration 로직 수정

9e78268

#9 [REFACTOR] snackbar duration 적용

f60cb61

#9 [DEL] 공백 제거

d9cb800

gaeulzzang reviewed Jan 21, 2025

View reviewed changes

Eonji-sw reviewed Jan 22, 2025

View reviewed changes

twogarlic added 7 commits January 23, 2025 13:45

[REFACTOR] 화면 연결

6031707

[REFACOTR] 코리 반영

d60f512

[REFACTOR] 스낵바 수정

c04acbe

[REFACTOR] 스낵바, 시간 형식 수정

7da103e

[MOD] ktlint 포맷

35b8cce

[REFACTOR] 코리반영

6fb3dea

[REFACTOR] 코드리뷰 반영

3c1c6e0

gaeulzzang approved these changes Jan 24, 2025

View reviewed changes

twogarlic merged commit a77f64b into develop Jan 24, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature/#9] : 약속 생성 UI 구현 #33

[Feature/#9] : 약속 생성 UI 구현 #33

twogarlic commented Jan 18, 2025

gaeulzzang left a comment

gaeulzzang Jan 19, 2025

twogarlic Jan 19, 2025

gaeulzzang Jan 19, 2025

twogarlic Jan 19, 2025

gaeulzzang Jan 19, 2025

twogarlic Jan 19, 2025

youjin09222 left a comment •

edited

Loading

youjin09222 Jan 20, 2025 •

edited

Loading

gaeulzzang Jan 21, 2025

gaeulzzang left a comment

Eonji-sw left a comment •

edited

Loading

Eonji-sw Jan 22, 2025

Eonji-sw Jan 22, 2025

Eonji-sw Jan 22, 2025

twogarlic Jan 23, 2025

Eonji-sw Jan 22, 2025

gaeulzzang left a comment

		val backgroundColor = if (checked) NoostakTheme.colors.mint else NoostakTheme.colors.gray200
		val thumbColor = NoostakTheme.colors.white

[Feature/#9] : 약속 생성 UI 구현 #33

[Feature/#9] : 약속 생성 UI 구현 #33

Conversation

twogarlic commented Jan 18, 2025

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

📌 𝗜𝘀𝘀𝘂𝗲𝘀

📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

gaeulzzang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youjin09222 left a comment • edited Loading

Choose a reason for hiding this comment

youjin09222 Jan 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaeulzzang left a comment

Choose a reason for hiding this comment

Eonji-sw left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaeulzzang left a comment

Choose a reason for hiding this comment

youjin09222 left a comment •

edited

Loading

youjin09222 Jan 20, 2025 •

edited

Loading

Eonji-sw left a comment •

edited

Loading