[Feature/#25] 마이페이지 UI 구현 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaeulzzang
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
아우 다이얼로그도 야무지게 타입으로 분류해놨네여 👍 특히 다이얼로그 띄우는 것도 사이드 이펙트로 빼놓아서 MVI를 잘 지키고 있는 것 같습니다
가로선이나 세로선은 divider 사용하고 버튼에 있는 리플 효과 제거하구 뷰모델명 명시적으로 바꿔주면 바로 머지해도 될 것 같아여
폰트도 바꾸고 컴포넌트도 수정하구.... 열람실에서 고생 많았어 엄마 ❤️😗
아마 로컬에 유저 정보 저장하는건 로그인하면서 유진 언니가 구현해야할 듯 싶습니답... @youjin09222 화이팅..
core/src/main/java/com/sopt/core/designsystem/component/chip/NoostakCategoryChip.kt
Show resolved
Hide resolved
core/src/main/java/com/sopt/core/designsystem/component/dialog/NoostakDialog.kt
Show resolved
Hide resolved
core/src/main/java/com/sopt/core/designsystem/component/dialog/NoostakDialog.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/sopt/core/designsystem/component/dialog/NoostakDialog.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/sopt/presentation/mypage/component/MyPageProfileEditButton.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/sopt/core/designsystem/component/dialog/NoostakDialog.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/sopt/core/designsystem/component/dialog/NoostakDialog.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/sopt/presentation/mypage/component/MyPageItem.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/sopt/presentation/mypage/component/MyPageProfileEditButton.kt
Show resolved
Hide resolved
youjin09222
approved these changes
Jan 22, 2025
core/src/main/java/com/sopt/core/designsystem/component/textfield/NoostakTextField.kt
Show resolved
Hide resolved
presentation/src/main/java/com/sopt/presentation/mypage/MyPageViewModel.kt
Show resolved
Hide resolved
# Conflicts: # presentation/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
2025-01-15.8.26.35.mov
2025-01-15.8.26.13.mov
2025-01-15.5.09.42.mov
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
textfield 걍 제가 수정된 사항까지 반영했슴다(대충해서 리팩 해주시면 고맙구 ㅎ..) 회원가입 페이지에서 button 활성화만 알맞게 해주세요
그리고 GroupCreateRoute 파일에서 focusManager 참고해서(해당 기능 적용되어 있음) 키보드 이외 영역 눌렀을 때 키보드 사라지게 처리해주세요 @youjin09222 하늘 언니도 요구사항에 있다면 해주세요 @twogarlic
textfield 가져다 쓸 때 꼭!! 기본값 확인해서 필요시 인자 넣어주세요 @youjin09222 @twogarlic
폰트 관련해서 수정 있을 것 같긴 한데 아직 디쟌이 답을 안줘서 나중에 하죠 뭐..
그룹 생성 실패 다이얼로그는 서버 통신할 때 적용해야해서 걍.. 영상에만 보여질 수 있도록 임의로 녹화했어요
로컬에 유저 정보 저장하는거 해야해요 누가 할래요? 플로우상 유진 언니가 하는 것이 나을 것 같긴 한데... @youjin09222 @gaeulzzang
회원가입, 로그인, 프로필에서 필요해서........ 아마도?