[Feature/#17] : 카카오 로그인, 구글 로그인 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaeulzzang
approved these changes
Jan 14, 2025
Comment on lines
53
to
55
| val signInRequest = com.google.android.gms.auth.api.identity.BeginSignInRequest.builder() | ||
| .setGoogleIdTokenRequestOptions( | ||
| com.google.android.gms.auth.api.identity.BeginSignInRequest.GoogleIdTokenRequestOptions.builder() |
There was a problem hiding this comment.
P2: Credential Manager로 리팩해보면 좋을 것 같아요!!
Eonji-sw
reviewed
Jan 14, 2025
There was a problem hiding this comment.
빠르게 잘하셨는걸용 아래 pr 참고해서 보완해도 좋을 것 같네욤
Team-Wable/WABLE-ANDROID#42
| LaunchedEffect(loginViewModel.sideEffects) { | ||
| loginViewModel.sideEffects.collect { sideEffect -> | ||
| when (sideEffect) { | ||
| is LoginSideEffect.NavigateToHome -> navigateToHome() | ||
| is LoginSideEffect.NavigateSignUp -> navigateToSignUp(sideEffect.authId) | ||
| is LoginSideEffect.ShowToast -> context.toast(sideEffect.message) |
There was a problem hiding this comment.
P3 : 실패했을 때 뜨는 스낵바나 다이얼로그 GUI 필요할듯요
There was a problem hiding this comment.
P1 : 로컬에 token 저장하는 로직 필요할 것 같아요 member id랑.. refresh token은 안받나요?
There was a problem hiding this comment.
서버 연결 로직 작성 시 발급받는 accessToken과 refreshToken를 저장하려고 하는데
이것과 별개로 카카오 및 구글 토큰도 저장해야하나요??
There was a problem hiding this comment.
아아 생각해보니 아직 서버 연결 전이네용 ㅋㅋㅋ 서버 연결 기준으로 말한거였어요! 흠 그래도 로컬에 토큰 제외하고 유저 정보 저장하는건 구현해놓으면 좋을 것 같아용 member id, nickname, ...
There was a problem hiding this comment.
넵! 해당 부분 수정하겠습니다!!
…into feature/#17-social-login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
login.mp4
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
늦어서 죄송합니다..
추가해야하는 파일 밑에 링크 참고해주세요!