Skip to content

Commit

Permalink
nextest.toml update to next-dev-tests and add retries (vercel#3456)
Browse files Browse the repository at this point in the history
This updates nextest.toml to use the new package name for next-dev
tests, `next-dev-tests` and adds up to 2 additional retries (for a total
of 3 attempts) since these tests tend to be flakey.

**Note**: This requires `cargo-nextest` version 0.9.49, which includes a
fix for nextest-rs/nextest#762. Otherwise, you
may receive an error when running nextest like:

```
error: failed to parse nextest config at `path/to/.config/nextest.toml`

Caused by:
  profile.default.overrides[0].leak-timeout: invalid type: string "500ms", expected struct Duration

Caused by:
  invalid type: string "500ms", expected struct Duration
```

Test Plan: Temporarily changed `slow-timeout` to `0s` and verified the
override selected next-dev tests by marking them as slow.
  • Loading branch information
wbinnssmith authored Jan 25, 2023
1 parent a4d3dae commit e36bf46
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions .config/nextest.toml
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
[profile.default]
[[profile.default.overrides]]
filter = "package(next-dev-tests)"
# Default is 100ms. Extending this addresses false positives in the
# next-dev integration tests.
#
# TODO: Move this to [[profile.default.overrides]] below
# Currently, doing so makes leak-timeout no longer parse as a duration:
# https://github.com/nextest-rs/nextest/issues/762
leak-timeout = "500ms"

[[profile.default.overrides]]
filter = "package(next-dev)"
retries = 2
slow-timeout = "60s"

0 comments on commit e36bf46

Please sign in to comment.