-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two terms could do with definition #5756
base: main
Are you sure you want to change the base?
Conversation
christopherreay
commented
Sep 16, 2024
- Because this PR includes a bug fix, relevant tests have been included.
- Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
- I didn't do anything of this.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -169,6 +169,8 @@ The third and fourth parameters are both optional. They represent the amount of | |||
|
|||
### Deploying a library | |||
|
|||
[ definition of "library".... I literally have no idea what this means. Library is an extremely abstract word in english ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to take a stab, this is what we mean: https://docs.soliditylang.org/en/latest/contracts.html#libraries
@@ -307,6 +309,8 @@ const token = m.contract("Token", ["My Token", "TKN2", 18], { from: account1 }); | |||
|
|||
## Using existing artifacts | |||
|
|||
> definition of "artifact" - an ABI? or... does this refer to the exact format of a hardhat artifact? link to a definitions? This documentation is excellent, and can be clearly understood. Artifact is a super abstract word in normal english. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And by artifact we mean a Hardhat compilation artifact: https://hardhat.org/hardhat-runner/docs/advanced/artifacts#compilation-artifacts