Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add test-all-solc-versions input to the core ci #5745

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

galargh
Copy link
Member

@galargh galargh commented Sep 13, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR restores the ability to run the tests for all solc versions in CI on demand. It doesn't change the default of running the tests only for the compiler versions marked as latest.

Here's an example run - https://github.com/NomicFoundation/hardhat/actions/runs/10846884277

Note that it currently fails with OOM errors :( These are the standard machines sizes - https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Do you think we should act on it?

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 6:46pm

Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: 879918d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Sep 13, 2024
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to give this an approval because it looks good to my eyes, but you probably know a lot more about workflows than me, so I'd ask for another reviewer if you're not totally sure about the changes 😄

Base automatically changed from support-solc-0.8.27 to main September 16, 2024 16:08
@galargh galargh added the no changeset needed This PR doesn't require a changeset label Sep 16, 2024
@galargh galargh marked this pull request as ready for review October 28, 2024 11:23
@galargh galargh merged commit 1c491eb into main Oct 28, 2024
105 of 106 checks passed
@galargh galargh deleted the galargh/ci-test-all-solidity-versions branch October 28, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants