fix: return no accounts if eth_accounts is deprecated
#5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 056704e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Erigon now responds that `eth_accounts` is deprecated when we make an RPC call. Instead of erroring we now return an empty set of accounts from `getSigners` if `eth_accounts` is deprecated. Fixes #5572.
kanej
force-pushed
the
fix/erigon_depcrecated_eth_accounts
branch
from
0d89ce7
to
056704e
Compare
alcuadrado
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erigon now responds that
eth_accountsis deprecated when we make an RPC call. Instead of erroring we now return an empty set of accounts fromhre.ethers.getSignersifeth_accountsis deprecated. Effectively we fall back with no unlocked accounts available from the node.Fixes #5572.
Manual Testing
This was tested by running a local Erigon node in dev mode, connecting to it via a Hardhat script and invoking
hre.ethers.getSigners().