Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add provider to edr_napi #4578

Merged
merged 2 commits into from
Nov 10, 2023
Merged

feat: add provider to edr_napi #4578

merged 2 commits into from
Nov 10, 2023

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Nov 9, 2023

No description provided.

@Wodann Wodann added the area:edr label Nov 9, 2023
@Wodann Wodann self-assigned this Nov 9, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0f39220

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 3:22pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 3:22pm

@Wodann Wodann linked an issue Nov 9, 2023 that may be closed by this pull request
Expose edr_provider::handle_request method in N-api NomicFoundation/edr#231
Closed
agostbiro
agostbiro requested changes Nov 10, 2023
View reviewed changes
crates/edr_napi/src/provider.rs Show resolved Hide resolved
crates/edr_napi/src/provider.rs Show resolved Hide resolved
crates/edr_napi/src/provider.rs Outdated Show resolved Hide resolved
@Wodann Wodann merged commit 7d25b1b into edr/main Nov 10, 2023
105 of 113 checks passed
@Wodann Wodann deleted the edr/feat/provider-napi branch November 10, 2023 19:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agostbiro agostbiro agostbiro approved these changes

@fvictorio fvictorio fvictorio approved these changes

Assignees

@Wodann Wodann

Labels
area:edr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose edr_provider::handle_request method in N-api
3 participants
@Wodann @fvictorio @agostbiro