Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stub the RPC server's logger #4534

Merged
merged 1 commit into from
Oct 27, 2023
Merged

feat: stub the RPC server's logger #4534

merged 1 commit into from
Oct 27, 2023

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Oct 26, 2023

No description provided.

@Wodann Wodann self-assigned this Oct 26, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

⚠️ No Changeset found

Latest commit: c000c08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 6:01pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 6:01pm

@Wodann Wodann linked an issue Oct 26, 2023 that may be closed by this pull request
Stub ModulesLogger NomicFoundation/edr#216
Closed
@agostbiro agostbiro merged commit d0e3775 into edr/main Oct 27, 2023
52 of 54 checks passed
@agostbiro agostbiro deleted the edr/feat/stubbed-logger branch October 27, 2023 10:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agostbiro agostbiro agostbiro approved these changes

@alcuadrado alcuadrado Awaiting requested review from alcuadrado

Assignees

@Wodann Wodann

Labels
area:edr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stub ModulesLogger
2 participants
@Wodann @agostbiro