Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: static state change error #4499

Merged
merged 3 commits into from
Oct 20, 2023
Merged

fix: static state change error #4499

merged 3 commits into from
Oct 20, 2023

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Oct 19, 2023

No description provided.

@Wodann Wodann self-assigned this Oct 19, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f983666

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 10:39pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 10:39pm

@Wodann Wodann linked an issue Oct 19, 2023 that may be closed by this pull request
OpenZeppelin test fails with AssertionError: Could not parse as custom error. Unmatched evm error: static state change NomicFoundation/edr#206
Closed
@Wodann Wodann mentioned this pull request Oct 19, 2023
Closed
@Wodann Wodann linked an issue Oct 19, 2023 that may be closed by this pull request
Test failures in the synthetix repo NomicFoundation/edr#207
Closed
agostbiro
agostbiro approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Wodann ! Added one comment, otherwise I'd defer to @fvictorio on the review of this.

packages/hardhat-core/src/internal/hardhat-network/provider/vm/exit.ts Outdated Show resolved Hide resolved
@agostbiro
Copy link
Member

I tried to resolve the merge conflict, but it's related to #4487 and it's not obvious what to do about it, so I'd leave it to you @Wodann

fvictorio
fvictorio reviewed Oct 19, 2023
View reviewed changes
packages/hardhat-core/src/internal/hardhat-network/stack-traces/vm-tracer.ts Outdated Show resolved Hide resolved
packages/hardhat-core/src/internal/hardhat-network/provider/vm/ethereumjs.ts Outdated
};
} else {
const vmError = Exit.fromEthereumJSEvmError(
// Override the exceptional halt reason with the one from the EVM result, to avoid lossy casting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this. The idea is to avoid converting it twice? Is that the lossy part?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, not all EvmErrors can be represented as an ExitCode, so we bypass the lossy conversion

@Wodann Wodann force-pushed the edr/fix/static-state-change branch from 0a5e37a to 9436474 Compare October 19, 2023 14:42
@Wodann Wodann merged commit 0680887 into rethnet/main Oct 20, 2023
94 of 99 checks passed
@Wodann Wodann deleted the edr/fix/static-state-change branch October 20, 2023 01:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fvictorio fvictorio fvictorio left review comments

@agostbiro agostbiro agostbiro approved these changes

Assignees

@Wodann Wodann

Labels
area:edr
Projects
None yet
Milestone
No milestone
3 participants
@Wodann @agostbiro @fvictorio