Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: debug trace call #4433

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat: debug trace call #4433

merged 3 commits into from
Oct 5, 2023

Conversation

agostbiro
Copy link
Member

Add EDR support for debug_traceCall. Please note that the base branch is #4410.

@agostbiro agostbiro requested a review from Wodann October 3, 2023 17:45
@agostbiro agostbiro self-assigned this Oct 3, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

⚠️ No Changeset found

Latest commit: 95e41f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 10:28am
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 10:28am

@Wodann
Copy link
Member

Wodann commented Oct 3, 2023

The code looks good.

Can you just fix the linter error before merging?

@agostbiro
Copy link
Member Author

The code looks good.

Can you just fix the linter error before merging?

Thanks, do you mean this lint? It seems to be failing in the base branch as well and I'm not sure what to do about it.

@fvictorio fvictorio force-pushed the hardhat-edr-merge branch 3 times, most recently from 854b91a to 978952b Compare October 4, 2023 09:12
@Wodann
Copy link
Member

Wodann commented Oct 4, 2023

Don't worry about it then 👍

@agostbiro
Copy link
Member Author

agostbiro commented Oct 4, 2023

Don't worry about it then 👍

Ok, I merged the base branch into this branch and the lint error seems to be fixed now, but there are a bunch provider test errors that are unrelated to this PR I think. Could you have a look at them @Wodann and merge the PR if you think they're ok?

@Wodann Wodann merged commit a7aa8d3 into hardhat-edr-merge Oct 5, 2023
65 of 75 checks passed
@Wodann Wodann deleted the rethnet/debug-trace-call branch October 5, 2023 07:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement debug_traceCall
2 participants