Noitidart/throbber restored

[ChasCB]

No description provided.

[Noitidart]

Hey man thanks so much for the pull req here. However you didn't edit bootstrap.js right? It was just a copy and paste? Can you please only edit the css file, because if we take that bootstrap.js it puts in a lot of debug comments and most of all it makes it that toolbaritem look again.

[Noitidart]

Actually I think I can take out just the changes, I'll send you an updated thing so you can use that as a pull req so i can get your name in here. Thanks so much for your work so juts hang tight please ill make a commit for you :)

[Noitidart]

Hmm it looks like the only edits to the css file are the CTR ids. I was hoping to get you rpadding fix so it doesn't strech things. I'll also add in that label to the bootstrap.js.

[ChasCB]

told you I am not good at java (at all).

I took out this bit

id: 'navigator-throbber',

•  type: 'custom',
  

•  defaultArea: CustomizableUI.AREA_NAVBAR,
  

•  onBuild: function(aDocument) {
  

•      var toolbaritem = aDocument.createElementNS('http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul', 'toolbaritem');
  

•      var image = aDocument.createElementNS('http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul', 'image');
  

•      var props = {
  

•          id: 'navigator-throbber',
  

•          title: 'Activity Indicator',
  

•          align: 'center',
  

•          pack: 'center',
  

•          mousethrough: 'always',
  

•          removable: 'true',
  

•          sdkstylewidget: 'true',
  

•          overflows: false
  

•      };
  

•      for (var p in props) {
  

•          toolbaritem.setAttribute(p, props[p]);
  

•      }
  

•      toolbaritem.appendChild(image);
  

•      return toolbaritem;
  

•  }
  

and left in:

•   id : 'navigator-throbber',
  

  •  defaultArea : CustomizableUI.AREA_NAVBAR,
    

  •  label : 'Loading',
    

  •  overflows: false
    

Chas

On 27/05/2014, at 21:01, Noitidart [email protected] wrote:

Hey man thanks so much for the pull req here. However you didn't edit bootstrap.js right? It was just a copy and paste? Can you please only edit the css file, because if we take that bootstrap.js it puts in a lot of debug comments and most of all it makes it that toolbaritem look again.

—
Reply to this email directly or view it on GitHub.

[ChasCB]

Actually as I am not good with at all with java and only moderately good with css/html I give you permission to log into github with my ID

[removed]

cheers

Chas

On 27/05/2014, at 21:04, Noitidart [email protected] wrote:

Hmm it looks like the only edits to the css file are the CTR ids. I was hoping to get you rpadding fix so it doesn't strech things. I'll also add in that label to the bootstrap.js.

—
Reply to this email directly or view it on GitHub.

[Noitidart]

Ah no no please I edited out your info for safety. Thanks for the trust though! Right now its 2:15am here, I'll write up a branch and then your way for testing than we'll get it on your account and merge that. :)

[ChasCB]

ok thanks - its 2110 here in Kiwi land and I spent the day at my mums 91st birthday so a bit under the weather at the mo.

Cheers

Chas

On 27/05/2014, at 21:11, Noitidart [email protected] wrote:

Ah no no please I edited out your info for safety. Thanks for the trust though! Right now its 2:15am here, I'll write up a branch and then your way for testing than we'll get it on your account and merge that. :)

—
Reply to this email directly or view it on GitHub.

[Noitidart]

Ah wow!! 91 thats so cool! Get well soon man! :)