-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP8.4 support #270
Add PHP8.4 support #270
Conversation
7da2231
to
e42d8a6
Compare
e42d8a6
to
4bc381e
Compare
Looks strange that clang on MacOS fails |
Yes, but only with PHP8.4, @AlexNDRmac do you see what is the issue ? https://github.com/NoiseByNorthwest/php-spx/actions/runs/11092707280/job/30818091475?pr=270 |
Looks like compile issue. As I know, php core team trying to move from C99 to smth like C++ standard. Redefinition warning should be resolved with #ifndef or forward declaration... but, it's php :) |
Indeed, 8.4 introduces this dependency to C11+ ✔ ~/dev/php-src [PHP-8.3 ↓·734|✔]
23:09 $ ack 'typedef\s+struct\s+_zend_string\s+'
Zend/zend_types.h
96:typedef struct _zend_string zend_string;
✔ ~/dev/php-src [PHP-8.3 ↓·734|✔]
23:09 $ git co PHP-8.4
Switched to branch 'PHP-8.4'
Your branch is up to date with 'origin/PHP-8.4'.
✔ ~/dev/php-src [PHP-8.4|✔]
23:09 $ ack 'typedef\s+struct\s+_zend_string\s+'
Zend/zend_map_ptr.h
24:typedef struct _zend_string zend_string;
Zend/zend_types.h
96:typedef struct _zend_string zend_string;
Zend/zend_smart_str_public.h
22:typedef struct _zend_string zend_string; |
34f97fd
to
1cf9d65
Compare
1cf9d65
to
fab08fe
Compare
@AlexNDRmac fixed, I've just disabled "typedef-redefinition" warning on macOS. |
always get like that for the latest/release branch |
@nhutnguyenvu your PHP version seems to be 8.2 |
No description provided.