Improve operations pre-processing

NoelDeMartin · Feb 7, 2025 · 269bac7 · 269bac7
1 parent 59f35d6
commit 269bac7
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/src/solid/RDFResourceProperty.ts b/src/solid/RDFResourceProperty.ts
@@ -142,6 +142,13 @@ abstract class RDFResourceProperty {
         }
     }
 
+    public valueEquals(other: RDFResourceProperty): boolean {
+        const value = this.value instanceof Date ? this.value.getTime() : this.value;
+        const otherValue = other.value instanceof Date ? other.value.getTime() : other.value;
+
+        return value === otherValue;
+    }
+
     protected getTurtleReference(
         value: string | null,
         documentUrl: string | null,

diff --git a/src/solid/SolidClient.test.ts b/src/solid/SolidClient.test.ts
@@ -832,14 +832,21 @@ describe('SolidClient', () => {
     it('ignores idempotent operations', async () => {
         // Arrange
         const documentUrl = faker.internet.url();
-        const data = '<> <http://www.w3.org/2000/01/rdf-schema#label> "Things" .';
+        const now = new Date();
+        const data = `
+            <>
+                <http://www.w3.org/2000/01/rdf-schema#label> "Things" ;
+                <http://purl.org/dc/terms/modified>
+                    "${now.toISOString()}"^^<http://www.w3.org/2001/XMLSchema#dateTime> .
+        `;
 
         StubFetcher.addFetchResponse(data);
         StubFetcher.addFetchResponse();
 
         // Act
         await client.updateDocument(documentUrl, [
             new UpdatePropertyOperation(RDFResourceProperty.literal(documentUrl, IRI('rdfs:label'), 'Things')),
+            new UpdatePropertyOperation(RDFResourceProperty.literal(documentUrl, IRI('purl:modified'), now)),
             new UpdatePropertyOperation(RDFResourceProperty.literal(documentUrl, IRI('foaf:name'), 'Things')),
         ]);
 

diff --git a/src/solid/SolidClient.ts b/src/solid/SolidClient.ts
@@ -170,6 +170,10 @@ export default class SolidClient {
         this.processChangeUrlOperations(document, operations);
         this.processUpdatePropertyOperations(document, operations);
 
+        if (operations.length === 0) {
+            return;
+        }
+
         document.resource(url)?.isType(LDP_CONTAINER)
             ? await this.updateContainerDocument(document, operations)
             : await this.updateNonContainerDocument(document, operations, options);
@@ -566,8 +570,8 @@ export default class SolidClient {
                 if (
                     currentProperty &&
                     otherProperties.length === 0 &&
-                    property.value === currentProperty.value &&
-                    property.type === currentProperty.type
+                    property.type === currentProperty.type &&
+                    property.valueEquals(currentProperty)
                 ) {
                     idempotentOperations.push(operation);
                 }