Nodeclipse issue #189 - workaround for node issue 25266 #193
Conversation
…g 'compileError' events instead of 'afterCompile' events, which causes nodeclipse to miss the chance to process new scripts as they are pulled into a running application
paulvi
changed the title
|
That makes it very clear what is to be changed. Next thing would be make a preference for that. Short: Description: Do you think short string would be enough? |
Nodeclipse issue #189 - workaround for node issue 25266
|
I think i'd go with something like "Treat Node Debugger compileError event as afterCompile (joyent/node#25266). The reasoning because...
Also, I would use joyent/node#25266 instead of joyent/node#23538. I think joyent/node#25266 matches more closely to what we experienced in this situation. |
@swingfield |
|
I'm not familiar with node issue 25358. But reading it, I do see that someone has linked that issue with node issue 25266, so maybe they are related in some way. But I think 25266 more clearly states the root of the problem that we are addressing in this Nodeclipse issue. |
|
OK, as I said now it is my turn to come out with preference checkbox |
Pull request that addresses Nodeclipse issue #189.
This is a workaround for node issue nodejs/node-v0.x-archive#25358, where node seems to be generating 'compileError' events instead of 'afterCompile' events. This causes Nodeclipse to miss the chance to process new scripts as they are pulled into a running application, as Nodeclipse is listening for the afterCompile events.
As discussed in Nodeclipse issue #189, if this does in fact turn out to be a node issue, then presumably this workaround would be version-specific, and would only need to be activated for certain versions of node.