Added node status by period in filter #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrigan
requested changes
Mar 19, 2020
src/Services/NodeUptimeService.ts
Outdated
| return await database.runQuery<NodeUptime>( | ||
| `select "isWorking",date_trunc('day', "updatedAt") "timePeriod", ( | ||
| case when "isWorking" = false | ||
| then 'Node is down' |
There was a problem hiding this comment.
Since this is an API, it's better and expected to use boolean (true/false) so frontend can parse it easier
There was a problem hiding this comment.
The idea was that the response also has a message that can be displayed, like { "isWorking": false, "timePeriod": "2020-03-17T00:00:00.000Z", "nodeStatus": "Node is down" }
Should I just leave the isWorking with timePeriod in the response?
There was a problem hiding this comment.
Also, please don't break current implementation by renaming variable, response should have the same structure
src/Services/NodeUptimeService.ts
Outdated
| else 'Node is up' | ||
| end) as "nodeStatus" | ||
| from "NodeUptime" | ||
| where "nodeId" = 1 |
src/Services/NodeUptimeService.ts
Outdated
| order: [['updatedAt', 'DESC']] | ||
| }); | ||
| return await database.runQuery<NodeUptime>( | ||
| `select "isWorking",date_trunc('day', "updatedAt") "timePeriod", ( |
src/Services/NodeUptimeService.ts
Outdated
| end) as "nodeStatus" | ||
| from "NodeUptime" | ||
| where "nodeId" = 1 | ||
| and "updatedAt" >= now() - interval '1 year' |
morrigan
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially covers #57 Return node status in period by filter.