Skip to content

Commit

Permalink
Merge branch 'main' into refactor/records-patterns
Browse files Browse the repository at this point in the history
  • Loading branch information
marcossevilla authored Jul 25, 2023
2 parents 668be7d + 10a9714 commit 6ec6e55
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 13 deletions.
2 changes: 1 addition & 1 deletion cli/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include: package:very_good_analysis/analysis_options.3.0.0.yaml
include: package:very_good_analysis/analysis_options.5.0.0.yaml

linter:
rules:
Expand Down
8 changes: 4 additions & 4 deletions cli/lib/commands/cov/commands/merge.dart
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,16 @@ Merge coverage data ignoring info related to files with paths that matches the g
@override
Future<void> run() async {
// Retrieve arguments and validate their value and the state they represent.
final _argResults = ArgumentError.checkNotNull(argResults);
final argumentResults = ArgumentError.checkNotNull(argResults);

final originPath = ArgumentError.checkNotNull(
_argResults[_originOption],
argumentResults[_originOption],
) as String;
final destinationPath = ArgumentError.checkNotNull(
_argResults[_destinationOption],
argumentResults[_destinationOption],
) as String;
final ignorePatterns = ArgumentError.checkNotNull(
_argResults[_ignorePatternsOption],
argumentResults[_ignorePatternsOption],
) as List<String>;

final envVars = Platform.environment;
Expand Down
4 changes: 0 additions & 4 deletions cli/lib/commands/rm/command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,15 @@ Future<void> run(List<String> args) async {
}
final elementPath = args.first;
final elementType = FileSystemEntity.typeSync(elementPath);
// ignore: exhaustive_cases
switch (elementType) {
case FileSystemEntityType.directory:
final dir = Directory(elementPath);
dir.deleteSync(recursive: true);
break;
case FileSystemEntityType.file:
final file = File(elementPath);
file.deleteSync(recursive: true);
break;
case FileSystemEntityType.notFound:
print('The element <$elementPath> does not exist');
break;
case FileSystemEntityType.pipe:
case FileSystemEntityType.link:
case FileSystemEntityType.unixDomainSock:
Expand Down
9 changes: 5 additions & 4 deletions cli/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ description: A set of utility commands.
version: 0.1.0+1

environment:
sdk: ">=2.18.0 <3.0.0"
sdk: ">=3.0.5 <4.0.0"

dependencies:
path: ^1.8.2
args: ^2.4.2
path: ^1.8.3

dev_dependencies:
test: ^1.17.12
very_good_analysis: ^3.0.0
test: ^1.24.4
very_good_analysis: ^5.0.0+1

0 comments on commit 6ec6e55

Please sign in to comment.