Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arima): handle zero sigma2 in CSS method #960

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

andrewscottm
Copy link
Contributor

Fixes error reported in #958

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #960 will not alter performance

Comparing andrewscottm:fix/auto-arima-css-zero-sigma (91a6220) with main (4a5cb06)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jmoralez jmoralez merged commit 9d0ea52 into Nixtla:main Dec 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoARIMA with CSS method fails if residuals are zero
2 participants