ci: build wheels and run tests on same job (#904)

Nixtla · Sep 12, 2024 · 1df8480 · 1df8480
1 parent 12f6654
commit 1df8480
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 93 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -14,9 +14,13 @@ env:
   NIXTLA_NUMBA_CACHE: "1"
 
 jobs:
-  build_wheels:
-    name: Build wheels for cp${{ matrix.python-version }}-${{ matrix.os-platform[1] }}
+  run-tests:
+    name: Run tests for cp${{ matrix.python-version }}-${{ matrix.os-platform[1] }}
     runs-on: ${{ matrix.os-platform[0] }}
+    timeout-minutes: 60
+    env:
+      CIBW_BUILD_FRONTEND: build[uv]
+      CIBW_ENVIRONMENT: NIXTLA_NUMBA_CACHE=1
     strategy:
       fail-fast: false
       matrix:
@@ -40,20 +44,42 @@ jobs:
         with:
           platforms: arm64
 
-      - name: Build wheels
+      - name: Set up uv
+        uses: astral-sh/setup-uv@d70817ce85e489f62dba96dc5d8f7a926e48bdd7 # v2.1.1
+        with:
+          version: "latest"
+
+      - name: Build wheels and run all tests
+        if: matrix.os-platform[0] == 'ubuntu-latest'
         uses: pypa/cibuildwheel@bd033a44476646b606efccdd5eed92d5ea1d77ad # v2.20.0
         env:
           CIBW_BUILD: cp${{ matrix.python-version }}-${{ matrix.os-platform[1] }}
+          CIBW_TEST_SKIP: "*linux_aarch64"
+          CIBW_BEFORE_TEST: yum install -y java
+          CIBW_TEST_COMMAND: >
+            uv pip install -r {project}/setup.py --extra all &&
+            nbdev_test --path {project}/nbs/ --skip_file_re "(distributed|prophet).*.ipynb" --pause 1.0 --do_print --timing &&
+            pytest --durations=0 {project}/action_files
+
+      - name: Build wheels and run local tests
+        if: matrix.os-platform[0] != 'ubuntu-latest'
+        uses: pypa/cibuildwheel@bd033a44476646b606efccdd5eed92d5ea1d77ad # v2.20.0
+        env:
+          CIBW_BUILD: cp${{ matrix.python-version }}-${{ matrix.os-platform[1] }}
+          CIBW_TEST_COMMAND: >
+            uv pip install -r {project}/setup.py --extra dev --extra plotly &&
+            nbdev_test --path {project}/nbs/ --skip_file_re "(distributed|prophet).*.ipynb" --pause 1.0 --do_print --timing
 
       - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
+        if: github.event_name == 'push'
         with:
           name: artifact-cp${{ matrix.python-version }}-${{ matrix.os-platform[1] }}
           path: wheelhouse/*.whl
           retention-days: 1
 
   publish-nightly-wheels:
     if: github.event_name == 'push'
-    needs: [build_wheels]
+    needs: [run-tests]
     env:
       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID_NIXTLA_PACKAGES }}
       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY_NIXTLA_PACKAGES }}
@@ -79,106 +105,21 @@ jobs:
           python action_files/update_index.py
           aws s3 sync dist s3://nixtla-packages/statsforecast/
 
-  run-local-tests:
-    needs: [build_wheels]
-    runs-on: ${{ matrix.os }}
-    timeout-minutes: 60
-    strategy:
-      fail-fast: false
-      matrix:
-        os: [macos-13, macos-14, windows-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
-    steps:
-      - name: Clone repo
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-        with:
-          submodules: "true"
-
-      - name: Set up environment
-        uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
-        with:
-          python-version: ${{ matrix.python-version }}
-
-      - name: Install pip requirements
-        run: pip install uv && uv pip install --system -r setup.py --extra dev --extra plotly
-
-      - name: Download wheels
-        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
-        with:
-          path: dist
-          pattern: "artifact-*"
-          merge-multiple: true
-
-      - name: Install the library
-        run: pip install --no-index --find-links dist statsforecast
-
-      - name: Run local tests
-        run: nbdev_test --skip_file_re '(distributed|prophet).*.ipynb' --pause 1.0 --do_print --timing
-
-  run-tests:
-    needs: [build_wheels]
+  test-m3-performance:
     runs-on: ubuntu-latest
-    timeout-minutes: 60
-    strategy:
-      fail-fast: false
-      matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
     steps:
       - name: Clone repo
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
         with:
           submodules: "true"
 
-      - name: Set up environment
-        uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
-        with:
-          python-version: ${{ matrix.python-version }}
-
-      - name: Install pip requirements
-        run: pip install uv && uv pip install --system -r setup.py --extra all
-
-      - name: Download wheels
-        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
-        with:
-          path: dist
-          pattern: "artifact-*"
-          merge-multiple: true
-
-      - name: Install the library
-        run: pip install --no-index --find-links dist statsforecast
-
-      - name: Run tests
-        run: nbdev_test --skip_file_re '(distributed|prophet).*.ipynb' --pause 1.0 --do_print --timing
-
-      - name: Run integration tests
-        run: |
-          uv pip install --system pytest
-          pytest --durations=0 action_files
-
-  test-m3-performance:
-    needs: [build_wheels]
-    runs-on: ubuntu-latest
-    steps:
-      - name: Clone repo
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-
       - name: Set up environment
         uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
         with:
           python-version: "3.10"
 
-      - name: Install pip requirements
-        run: pip install uv && uv pip install --system -r setup.py --extra dev
-
-      - name: Download wheels
-        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
-        with:
-          path: dist
-          pattern: "artifact-*"
-          merge-multiple: true
-
       - name: Install the library
-        run: pip install --no-index --find-links dist statsforecast
+        run: pip install uv && uv pip install --system ".[dev]"
 
       - name: Run M3 experiment
         run: |

diff --git a/pyproject.toml b/pyproject.toml
@@ -5,7 +5,6 @@ build-backend = "setuptools.build_meta"
 [tool.cibuildwheel]
 archs = "all"
 build-verbosity = 1
-test-skip = "*"
 
 [tool.ruff]
 target-version = "py38"

diff --git a/settings.ini b/settings.ini
@@ -21,7 +21,7 @@ ray_requirements = fugue[ray]>=0.8.1 protobuf>=3.15.3,<4.0.0 numpy<2 pandas<2.2
 dask_requirements = fugue[dask]>=0.8.1
 spark_requirements = fugue[spark]>=0.8.1
 plotly_requirements = plotly plotly-resampler
-dev_requirements = black datasetsforecast fire nbdev nbformat nbdev_plotly pandas[plot] pmdarima polars[numpy] pre-commit prophet pyarrow pybind11 scikit-learn setuptools<70 supersmoother
+dev_requirements = black datasetsforecast fire nbdev nbformat nbdev_plotly pandas[plot] pmdarima polars[numpy] pre-commit prophet pyarrow pybind11 pytest scikit-learn setuptools<70 supersmoother
 nbs_path = nbs
 doc_path = _docs
 recursive = True