Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved regular reviews #16

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Improved regular reviews #16

merged 3 commits into from
Jul 25, 2024

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jul 11, 2024

This improves the regular monthly reviews (such as this one) by:

I already tested this in a separate repo: Infinisil-s-Test-Organization/some-test#8

@zimbatm To make this work, the GitHub app (https://github.com/NixOS/org/settings/installations) needs extra permissions, specifically the "Organization/Members/read-only" permission. Once you added the extra permission, you'll have to go to the installation and confirm the new permission.


This work is sponsored by Antithesis

The monthly reviews mention teams, but that doesn't give a notification
to the team, see also https://github.com/orgs/community/discussions/39049.

This commit fixes that by expanding the team to the users that are part
of it.
@infinisil infinisil requested a review from a team as a code owner July 11, 2024 19:19
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the changes to the GitHub app

@infinisil infinisil merged commit da5ea7e into main Jul 25, 2024
2 checks passed
@infinisil infinisil deleted the improved-reviews branch July 25, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants