Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py7zr: init at 0.22.0; pyppmd: init at 1.1.1; pybcj: init at 1.0.3; multivolumefile: init at 0.2.3; inflate64: init at 1.0.1 #384329

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

pitkling
Copy link
Member

@pitkling pitkling commented Feb 22, 2025

Continues the work done by @poperigby (in PR #365111) and @ByteSudoer (in PR #324293).

Commit Explanation:

Potential Reviewers

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pitkling
Copy link
Member Author

@poperigby: I kept you as a maintainer (as by your original PR); let me know if that's ok.

Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continuing this work. This is looking good!

I've left some comments for a few minor things I think could be cleaned up a little.

@MattSturgeon
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384329


x86_64-linux

✅ 20 packages built:
  • py7zr (python312Packages.py7zr)
  • py7zr.dist (python312Packages.py7zr.dist)
  • python312Packages.inflate64
  • python312Packages.inflate64.dist
  • python312Packages.multivolumefile
  • python312Packages.multivolumefile.dist
  • python312Packages.pybcj
  • python312Packages.pybcj.dist
  • python312Packages.pyppmd
  • python312Packages.pyppmd.dist
  • python313Packages.inflate64
  • python313Packages.inflate64.dist
  • python313Packages.multivolumefile
  • python313Packages.multivolumefile.dist
  • python313Packages.py7zr
  • python313Packages.py7zr.dist
  • python313Packages.pybcj
  • python313Packages.pybcj.dist
  • python313Packages.pyppmd
  • python313Packages.pyppmd.dist

Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff lgtm, once the tmp commits are squashed.

@MattSturgeon MattSturgeon added 8.has: package (new) This PR adds a new package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 22, 2025
@pitkling
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384329


aarch64-darwin

✅ 20 packages built:
  • py7zr (python312Packages.py7zr)
  • py7zr.dist (python312Packages.py7zr.dist)
  • python312Packages.inflate64
  • python312Packages.inflate64.dist
  • python312Packages.multivolumefile
  • python312Packages.multivolumefile.dist
  • python312Packages.pybcj
  • python312Packages.pybcj.dist
  • python312Packages.pyppmd
  • python312Packages.pyppmd.dist
  • python313Packages.inflate64
  • python313Packages.inflate64.dist
  • python313Packages.multivolumefile
  • python313Packages.multivolumefile.dist
  • python313Packages.py7zr
  • python313Packages.py7zr.dist
  • python313Packages.pybcj
  • python313Packages.pybcj.dist
  • python313Packages.pyppmd
  • python313Packages.pyppmd.dist

@GaetanLepage
Copy link
Contributor

GaetanLepage commented Feb 23, 2025

@pitkling can you please clean the git history?

@pitkling
Copy link
Member Author

@pitkling can you please clean the git history?

@GaetanLepage: Just cleaned it up (and added two comments with references to the upstream PRs I created for the two substitutions).

@MattSturgeon
Copy link
Contributor

and added two comments with references to the upstream PRs I created for the two substitutions

Awesome, thanks for submitting those. If either merge before this one, you could use fetchpatch2 to fetch the patch instead of implementing it in nixpkgs. Although this isn't a big deal either way.

@pitkling
Copy link
Member Author

pitkling commented Feb 23, 2025

@SuperSandro2000: Thanks for the formatting & ref/tag fixes, I just implemented them as you suggested.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384329


x86_64-linux

✅ 20 packages built:
  • py7zr (python312Packages.py7zr)
  • py7zr.dist (python312Packages.py7zr.dist)
  • python312Packages.inflate64
  • python312Packages.inflate64.dist
  • python312Packages.multivolumefile
  • python312Packages.multivolumefile.dist
  • python312Packages.pybcj
  • python312Packages.pybcj.dist
  • python312Packages.pyppmd
  • python312Packages.pyppmd.dist
  • python313Packages.inflate64
  • python313Packages.inflate64.dist
  • python313Packages.multivolumefile
  • python313Packages.multivolumefile.dist
  • python313Packages.py7zr
  • python313Packages.py7zr.dist
  • python313Packages.pybcj
  • python313Packages.pybcj.dist
  • python313Packages.pyppmd
  • python313Packages.pyppmd.dist

aarch64-linux

✅ 20 packages built:
  • py7zr (python312Packages.py7zr)
  • py7zr.dist (python312Packages.py7zr.dist)
  • python312Packages.inflate64
  • python312Packages.inflate64.dist
  • python312Packages.multivolumefile
  • python312Packages.multivolumefile.dist
  • python312Packages.pybcj
  • python312Packages.pybcj.dist
  • python312Packages.pyppmd
  • python312Packages.pyppmd.dist
  • python313Packages.inflate64
  • python313Packages.inflate64.dist
  • python313Packages.multivolumefile
  • python313Packages.multivolumefile.dist
  • python313Packages.py7zr
  • python313Packages.py7zr.dist
  • python313Packages.pybcj
  • python313Packages.pybcj.dist
  • python313Packages.pyppmd
  • python313Packages.pyppmd.dist

x86_64-darwin

✅ 20 packages built:
  • py7zr (python312Packages.py7zr)
  • py7zr.dist (python312Packages.py7zr.dist)
  • python312Packages.inflate64
  • python312Packages.inflate64.dist
  • python312Packages.multivolumefile
  • python312Packages.multivolumefile.dist
  • python312Packages.pybcj
  • python312Packages.pybcj.dist
  • python312Packages.pyppmd
  • python312Packages.pyppmd.dist
  • python313Packages.inflate64
  • python313Packages.inflate64.dist
  • python313Packages.multivolumefile
  • python313Packages.multivolumefile.dist
  • python313Packages.py7zr
  • python313Packages.py7zr.dist
  • python313Packages.pybcj
  • python313Packages.pybcj.dist
  • python313Packages.pyppmd
  • python313Packages.pyppmd.dist

aarch64-darwin

✅ 20 packages built:
  • py7zr (python312Packages.py7zr)
  • py7zr.dist (python312Packages.py7zr.dist)
  • python312Packages.inflate64
  • python312Packages.inflate64.dist
  • python312Packages.multivolumefile
  • python312Packages.multivolumefile.dist
  • python312Packages.pybcj
  • python312Packages.pybcj.dist
  • python312Packages.pyppmd
  • python312Packages.pyppmd.dist
  • python313Packages.inflate64
  • python313Packages.inflate64.dist
  • python313Packages.multivolumefile
  • python313Packages.multivolumefile.dist
  • python313Packages.py7zr
  • python313Packages.py7zr.dist
  • python313Packages.pybcj
  • python313Packages.pybcj.dist
  • python313Packages.pyppmd
  • python313Packages.pyppmd.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very close.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 24, 2025
pitkling and others added 6 commits February 24, 2025 10:15
Co-authored-by: ByteSudoer <[email protected]>
Co-authored-by: PopeRigby <[email protected]>
Co-authored-by: ByteSudoer <[email protected]>
Co-authored-by: Matt Sturgeon <[email protected]>
Co-authored-by: PopeRigby <[email protected]>
Co-authored-by: ByteSudoer <[email protected]>
Co-authored-by: PopeRigby <[email protected]>
Co-authored-by: ByteSudoer <[email protected]>
Co-authored-by: PopeRigby <[email protected]>
Co-authored-by: ByteSudoer <[email protected]>
Co-authored-by: Matt Sturgeon <[email protected]>
Co-authored-by: PopeRigby <[email protected]>
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your patience @pitkling

@GaetanLepage GaetanLepage merged commit 7c08de1 into NixOS:master Feb 24, 2025
25 of 27 checks passed
@pitkling pitkling deleted the inits/py7zr branch February 24, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: py7zr
5 participants