-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py7zr: init at 0.22.0; pyppmd: init at 1.1.1; pybcj: init at 1.0.3; multivolumefile: init at 0.2.3; inflate64: init at 1.0.1 #384329
Conversation
@poperigby: I kept you as a maintainer (as by your original PR); let me know if that's ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for continuing this work. This is looking good!
I've left some comments for a few minor things I think could be cleaned up a little.
pkgs/development/python-modules/multivolumefile/fix-pyproject-toml-typo.patch
Outdated
Show resolved
Hide resolved
0f4a1a4
to
549476f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff lgtm, once the tmp commits are squashed.
|
@pitkling can you please clean the git history? |
549476f
to
4b5910d
Compare
@GaetanLepage: Just cleaned it up (and added two comments with references to the upstream PRs I created for the two substitutions). |
Awesome, thanks for submitting those. If either merge before this one, you could use |
4b5910d
to
d051e63
Compare
@SuperSandro2000: Thanks for the formatting & ref/tag fixes, I just implemented them as you suggested. |
d051e63
to
6b4afa2
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very close.
Co-authored-by: ByteSudoer <[email protected]> Co-authored-by: PopeRigby <[email protected]>
Co-authored-by: ByteSudoer <[email protected]> Co-authored-by: Matt Sturgeon <[email protected]> Co-authored-by: PopeRigby <[email protected]>
Co-authored-by: ByteSudoer <[email protected]> Co-authored-by: PopeRigby <[email protected]>
Co-authored-by: ByteSudoer <[email protected]> Co-authored-by: PopeRigby <[email protected]>
Co-authored-by: ByteSudoer <[email protected]> Co-authored-by: Matt Sturgeon <[email protected]> Co-authored-by: PopeRigby <[email protected]>
6b4afa2
to
b83d795
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your patience @pitkling
Continues the work done by @poperigby (in PR #365111) and @ByteSudoer (in PR #324293).
Commit Explanation:
pyzstd
. It was originally part of PR py7zr: init at 0.22.0 #365111 but has been added in another PR umu-launcher: 1.1.4 -> 1.2.5 & init pyzstd #381975 by @MattSturgeon that has been merged.py7zr
(upstream PR: replace inaccessible mirror (qt.mirrors.tds.net) in test miurahr/py7zr#637)pyproject.toml
ofmultivolumefile
(upstream PR)Potential Reviewers
pyzstd
from the original PRspyzstd
in PR umu-launcher: 1.1.4 -> 1.2.5 & init pyzstd #381975Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.