Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_22: 1.22.11 -> 1.22.12 #379394

Merged
merged 1 commit into from
Feb 4, 2025
Merged

go_1_22: 1.22.11 -> 1.22.12 #379394

merged 1 commit into from
Feb 4, 2025

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Feb 4, 2025

Fixes

crypto/elliptic: timing sidechannel for P-256 on ppc64le

Due to the usage of a variable time instruction in the assembly implementation
of an internal function, a small number of bits of secret scalars are leaked on
the ppc64le architecture. Due to the way this function is used, we do not
believe this leakage is enough to allow recovery of the private key when P-256
is used in any well known protocols.

This is CVE-2025-22866 and Go issue https://go.dev/issue/71383.

changelog: https://github.com/golang/go/issues?q=milestone%3AGo1.22.12+label%3ACherryPickApproved

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen katexochen added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Feb 4, 2025
@katexochen katexochen added backport release-24.11 Backport PR automatically and removed 6.topic: golang labels Feb 4, 2025
@nix-owners nix-owners bot requested review from kalbasit, Mic92 and zowoq February 4, 2025 18:47
@katexochen katexochen removed the 1.severity: security Issues which raise a security issue, or PRs that fix one label Feb 4, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 4, 2025
@zowoq zowoq merged commit 74b26bd into NixOS:master Feb 4, 2025
28 of 31 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 4, 2025

Successfully created backport PR for release-24.11:

@katexochen katexochen deleted the go_1_22/12 branch February 5, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: golang 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants