scalene: 1.5.49 -> 1.5.51 #376439
Merged
scalene: 1.5.49 -> 1.5.51 #376439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahec
added
11.by: package-maintainer
sarahec
force-pushed
the
push-xmzwmnqvsvvl
branch
from
c61094f to
19f7b4f
Compare
sarahec
changed the title
sarahec
force-pushed
the
push-xmzwmnqvsvvl
branch
from
19f7b4f to
d55592b
Compare
|
GaetanLepage
reviewed
Feb 1, 2025
| @@ -109,5 +109,6 @@ buildPythonPackage rec { | |||
| mainProgram = "scalene"; | |||
| license = licenses.asl20; | |||
| maintainers = with maintainers; [ sarahec ]; | |||
| platforms = [ "x86_64-linux" ]; | |||
There was a problem hiding this comment.
The software is advertised to be compatible with MacOS and ARM-linux too.
If our package is not working for those platforms, you would need to add them to badPlatforms instead and add comments explaining why/how it fails.
There was a problem hiding this comment.
Done. I'll work with upstream to sort out a solution.
sarahec
force-pushed
the
push-xmzwmnqvsvvl
branch
2 times, most recently
from
3f9978a to
d11cf17
Compare
sarahec
force-pushed
the
push-xmzwmnqvsvvl
branch
from
d11cf17 to
00d9e86
Compare
GaetanLepage
reviewed
Feb 2, 2025
|
sarahec
force-pushed
the
push-xmzwmnqvsvvl
branch
from
00d9e86 to
e5666a0
Compare
|
GaetanLepage
approved these changes
Feb 2, 2025
|
@GaetanLepage thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why this is justified
Adding back the other platforms will require major changes to the derivation and some help from upstream. Since it's only been building for x86_64-Linux all along, we'll mark that as the only supported platform for now.
Release update
Improved GPU/Neuron profiling; fixed encoding issue Latest
v1.5.50
plasma-umass/scalene@2493277
What's Changed
Don't change JIT behavior on Neuron by @emeryberger in plasma-umass/scalene#896
Optimized implementation to use IOKit directly by @emeryberger in plasma-umass/scalene#897
Fix UTF-8 encoding issue, resolving plasma-umass/scalene#899 by @emeryberger in plasma-umass/scalene#900
Full Changelog: plasma-umass/scalene@v1.5.49...v1.5.50
1.5.51 Adds Python 3.13 support
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.