Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal_1_15: init at 1.15.1 #372897

Merged
merged 1 commit into from
Feb 5, 2025
Merged

crystal_1_15: init at 1.15.1 #372897

merged 1 commit into from
Feb 5, 2025

Conversation

MisileLab
Copy link
Contributor

@MisileLab MisileLab commented Jan 11, 2025

https://github.com/crystal-lang/crystal/releases/tag/1.15.0
https://github.com/crystal-lang/crystal/releases/tag/1.15.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MisileLab
Copy link
Contributor Author

I don't know why but test failed. (I'll disable check for now)

log
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/5pf3y04x2llgaajwwsbc2ph8va2az10l-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
applying patch /nix/store/k8sabp3qlshqn7lq7f8ij23w2hvinl8y-tzdata.patch
patching file src/crystal/system/unix/time.cr
Hunk #1 succeeded at 72 (offset 29 lines).
substituteStream() in derivation crystal-1.15.0: WARNING: '--replace' is deprecated, use --replace-{fail,warn,quiet}. (file 'Makefile')
substituteStream() in derivation crystal-1.15.0: WARNING: pattern /bin/ls doesn't match anything in file 'spec/std/file_spec.cr'
substituteStream() in derivation crystal-1.15.0: WARNING: pattern /usr/share doesn't match anything in file 'spec/std/file_spec.cr'
substituteStream() in derivation crystal-1.15.0: WARNING: pattern /usr doesn't match anything in file 'spec/std/file_spec.cr'
substituteStream() in derivation crystal-1.15.0: WARNING: pattern /tmp doesn't match anything in file 'spec/std/file_spec.cr'
substituteStream() in derivation crystal-1.15.0: WARNING: pattern /usr doesn't match anything in file 'spec/std/process_spec.cr'
substituteStream() in derivation crystal-1.15.0: WARNING: pattern /tmp doesn't match anything in file 'spec/std/process_spec.cr'
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
build flags: -j16 SHELL=/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash CRYSTAL_CONFIG_VERSION=1.15.0 progress=1 all docs release=1
Using /nix/store/4w20wsix4j5cpisgdh7xyx3sgp6wgxix-llvm-18.1.8-dev/bin/llvm-config [version=18.1.8]
CRYSTAL_CONFIG_BUILD_COMMIT="" CRYSTAL_CONFIG_PATH='$ORIGIN/../share/crystal/src' SOURCE_DATE_EPOCH="315532800"  CRYSTAL_CONFIG_LIBRARY_PATH='$ORIGIN/../lib/crystal' ./bin/crystal build --single-module -D strict_multi_assign -D preview_overload_order --release --progress --threads 16 -Dwithout_interpreter  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib -D use_pcre2
./bin/crystal docs src/docs_main.cr  --project-name=Crystal --project-version=1.15.0 --source-refname=
Using compiled compiler at .build/crystal
cp -R -P -p doc/ docs/
buildPhase completed in 7 minutes 45 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
check flags: -j16 SHELL=/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash CRYSTAL_CONFIG_VERSION=1.15.0 progress=1 VERBOSE=y compiler_spec
Using /nix/store/4w20wsix4j5cpisgdh7xyx3sgp6wgxix-llvm-18.1.8-dev/bin/llvm-config [version=18.1.8]
CRYSTAL_CONFIG_BUILD_COMMIT="" CRYSTAL_CONFIG_PATH='$ORIGIN/../share/crystal/src' SOURCE_DATE_EPOCH="315532800" ./bin/crystal build --single-module -D strict_multi_assign -D preview_overload_order --progress --threads 16 -Dwithout_interpreter  --exclude-warnings spec/std --exclude-warnings spec/compiler --exclude-warnings spec/primitives -o .build/compiler_spec spec/compiler_spec.cr --release
Using compiled compiler at .build/crystal
In lib/markd/src/markd/renderers/html_renderer.cr:238:7

 238 | {% if Crystal::VERSION < "1.2.0" %}
       ^
Warning: expanding macro


There was a problem expanding macro 'macro_140735789495712'

Called macro defined in lib/markd/src/markd/renderers/html_renderer.cr:238:7

 238 | {% if Crystal::VERSION < "1.2.0" %}

Which expanded to:

   1 | 
 > 2 |         title = URI.encode(node.first_child.text)
   3 |         @output_io << %(<a id="anchor-) << title << %(" class="anchor" href="#anchor-) << title << %("></a>)
   4 |       
Warning: Deprecated URI.encode. Use `.encode_path` instead.

A total of 1 warnings were found.
.build/compiler_spec --order=random             
Randomized with seed: 34669
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................*.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................*...........*.........................................................................................................................................................................................................................................................................................................................................................*............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Invalid memory access (signal 11) at address 0x7fffd5484410
[0x483189] ??Invalid memory access (signal  +4731273 in .build/compiler_spec
11) at address [0x0x7fffd5484830483140
] ?? +4731200 in .build/compiler_specInvalid memory access (signal 
11) at address 0x[7fffd5484c500x
7fffee240a70] [0x483189] ?? +4731273 in .build/compiler_spec
[??0x[ +4831890x140737188727408] 483140 in ] /nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/libc.so.6????
 + +[473127347312000x in  in 7ffff7deecfb.build/compiler_spec.build/compiler_spec] 

?? +[140737351970043[0x in 0x7fffee240a70/nix/store/3j1p598fivxs69wx3a657ysv3rw8k06l-pcre2-10.44/lib/libpcre2-8.so.0483140] 
] [??0x +7ffff7e23d434731200]  in ??.build/compiler_spec +
140737352187203?? in  +[/nix/store/3j1p598fivxs69wx3a657ysv3rw8k06l-pcre2-10.44/lib/libpcre2-8.so.01407371887274080x
 in 7fffee240a70/nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/libc.so.6[] 
0x[7ffff7dd88ea0x] 7ffff7deecfbpcre2_code_free_8]  +????26 + + in 140737351970043140737188727408/nix/store/3j1p598fivxs69wx3a657ysv3rw8k06l-pcre2-10.44/lib/libpcre2-8.so.0 in  in 
/nix/store/3j1p598fivxs69wx3a657ysv3rw8k06l-pcre2-10.44/lib/libpcre2-8.so.0/nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/libc.so.6[

0x[[7fffee8b33ff0x0x] 7ffff7e23d437ffff7deecfb] GC_invoke_finalizers] ?? +?? +79 +140737352187203 in 140737351970043 in /nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.1 in /nix/store/3j1p598fivxs69wx3a657ysv3rw8k06l-pcre2-10.44/lib/libpcre2-8.so.0
/nix/store/3j1p598fivxs69wx3a657ysv3rw8k06l-pcre2-10.44/lib/libpcre2-8.so.0

[[[0x0x0x7fffee8b364a7ffff7dd88ea7ffff7e23d43] ] ] pcre2_code_free_8???? + + +26140737352187203140737195488842 in  in  in /nix/store/3j1p598fivxs69wx3a657ysv3rw8k06l-pcre2-10.44/lib/libpcre2-8.so.0/nix/store/3j1p598fivxs69wx3a657ysv3rw8k06l-pcre2-10.44/lib/libpcre2-8.so.0/nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.1


[[[0x0x0x7fffee8b33ff7ffff7dd88ea7fffee8c64c7] ] ] pcre2_code_free_8 +26GC_generic_malloc in  +GC_invoke_finalizers/nix/store/3j1p598fivxs69wx3a657ysv3rw8k06l-pcre2-10.44/lib/libpcre2-8.so.039 +
 in 79[/nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.1 in 0x
/nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.17fffee8b33ff[
] 0x[7fffee8c68340x] 7fffee8b364a] GC_malloc_kind_globalGC_invoke_finalizers + +30879?? in  in  +/nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.1/nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.1140737195488842

 in [/nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.1[0x
0x7fffee8b364a[488792] 0x] 7fffee8c64c7????]  + +1407371954888424753298 in GC_generic_malloc in /nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.1 +.build/compiler_spec
39
 in [/nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.10x
7fffee8c64c7[] 0x[7fffee8c68340x] GC_generic_malloca28fa4GC_malloc_kind_global +]  +39??308 in  + in /nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.110653604/nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.1
 in 
.build/compiler_spec[
0x[7fffee8c68340x] [488792GC_malloc_kind_global0x]  +9811a2308] ?? in ?? +/nix/store/drx2jy36m21fis5k3mw7n6ffx87a9q12-boehm-gc-8.2.8/lib/libgc.so.1 +4753298
9965986 in  in .build/compiler_spec.build/compiler_spec
[
0x488792] [[??0x0x +a28fa4790be84753298] ]  in ????.build/compiler_spec + +
793290410653604 in  in .build/compiler_spec.build/compiler_spec[

0xa28fa4] [??[0x +0x9811a210653604ec64b5]  in ] ??.build/compiler_spec?? +
 +996598615492277 in  in .build/compiler_spec.build/compiler_spec[

0x9811a2[] 0x[??edf9140x +] 790be89965986??]  in  +??.build/compiler_spec15595796 +
 in 7932904.build/compiler_spec[ in 
0x.build/compiler_spec[790be8
0x] dd4b56??[]  +0x??7932904ec64b5 + in ] 14502742.build/compiler_spec?? in 
 +.build/compiler_spec15492277[
 in 0x.build/compiler_specec64b5[
] 0x[??dd33a30x +] edf91415492277??]  in  +??.build/compiler_spec14496675 +
 in 15595796[.build/compiler_spec in 0x
.build/compiler_specedf914[
] 0x[??dd5e460x +] dd4b5615595796??]  in  +??.build/compiler_spec14507590 +
 in 14502742.build/compiler_spec[ in 
0x.build/compiler_specdd4b56
[] 0x??[dca115 +0x] 14502742dd33a3?? in ]  +.build/compiler_spec??14459157
 + in [14496675.build/compiler_spec0x in 
dd33a3.build/compiler_spec] 
?? +[144966750x in dd5e46.build/compiler_spec] 
??[ +0x14507590dd5e46 in ] .build/compiler_spec??
 +[145075900x[ in 12fbcc90x.build/compiler_spec] dca115
] ???? +[ +199057370x14459157 in dca115 in .build/compiler_spec] .build/compiler_spec
??
[ +0x[144591574274160x in ] 12fbcc9.build/compiler_spec] main
?? +[ +6199057370x in  in 12fbcc9.build/compiler_spec.build/compiler_spec] 

??[[ +0x0x199057377fffee22a1fc427416 in ] ] .build/compiler_spec
main[ +0x6427416 in ??] .build/compiler_spec +
140737188635132main[ in  +0x/nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/libc.so.667fffee22a1fc
 in ] [.build/compiler_spec0x
7fffee22a2b9[] 0x7fffee22a1fc] __libc_start_main +137 in ??/nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/libc.so.6 +
140737188635132[ in 0x/nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/libc.so.640cd95
] ??[ +_start0x140737188635132 +7fffee22a2b9 in ] 37/nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/libc.so.6 in 
.build/compiler_spec[
0x__libc_start_main[7fffee22a2b9 +0x] 1370 in ] /nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/libc.so.6__libc_start_main???
 +[
1370x in 40cd95/nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/libc.so.6] 
[_start0x +40cd9537]  in .build/compiler_spec_start
 +[370x in 0.build/compiler_spec] 
???[
0x0] ???

BUG: a codegen process failed
make: *** [Makefile:122: compiler_spec] Error 1

@donovanglover
Copy link
Member

Can someone run nixpkgs-review on x86-64_linux?

@MisileLab
Copy link
Contributor Author

Can someone run nixpkgs-review on x86-64_linux?

I'll do it on server

@MisileLab
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372897


x86_64-linux

❌ 3 packages failed to build:
  • ahk_x11
  • ameba
  • rtfm
✅ 19 packages built:
  • amqpcat
  • blahaj
  • collision
  • crystal (crystal_1_15)
  • crystal.bin (crystal_1_15.bin)
  • crystal.lib (crystal_1_15.lib)
  • crystal2nix
  • crystalline
  • gi-crystal
  • icr
  • invidious
  • kakoune-cr
  • lucky-cli
  • mint
  • oq
  • scry
  • shards (shards_0_17)
  • thicket
  • tmuxPlugins.fingers

@MisileLab
Copy link
Contributor Author

MisileLab commented Jan 30, 2025

ahk_x11 error:

Error target ahk_x11 failed to compile:
Showing last frame. Use --error-trace for full trace.

In src/run/display/x11.cr:270:26

 270 | record_fd.not_nil!.wait_readable
                          ^------------
Error: undefined method 'wait_readable' for IO::FileDescriptor

make[1]: *** [Makefile:42: bin/ahk_x11.dev] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:32: bin/ahk_x11] Error 2

ameba error:

src/ameba/ast/variabling/argument.cr:1:1 [Correctable]
[W] Lint/Formatting: Use built-in formatter to format this source
> module Ameba::AST
  ^

Finished in 621.63 milliseconds
252 inspected, 1 failure
make: *** [Makefile:13: lint] Error 1

rtfm error

Error target rtfm failed to compile:
Module validation failed: !dbg attachment points at wrong subprogram for function
!4315 = distinct !DISubprogram(name: "main", linkageName: "main", scope: !19, file: !19, line: 1, type: !5, scopeLine: 1, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition | DISPFlagOptim>
ptr @main
  %status = alloca i32, align 4, !dbg !4316
!4316 = !DILocation(line: 8, column: 1, scope: !4317)
!4317 = distinct !DISubprogram(name: "main", linkageName: "main", scope: !4318, file: !4318, line: 8, type: !5, scopeLine: 8, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition | DISPFlagO>
!4317 = distinct !DISubprogram(name: "main", linkageName: "main", scope: !4318, file: !4318, line: 8, type: !5, scopeLine: 8, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition | DISPFlagO>
 (Exception)
  from /build/source/src/llvm/module.cr:83:9 in 'codegen'
  from /build/source/src/compiler/crystal/compiler.cr:220:15 in 'compile'
  from /build/source/src/compiler/crystal/command.cr:359:5 in 'run'
  from /build/source/src/compiler/crystal.cr:11:1 in '__crystal_main'
  from /build/source/src/crystal/main.cr:118:5 in 'main'
  from /build/source/src/crystal/system/unix/main.cr:10:3 in 'main'
  from /nix/store/h7zcxabfxa7v5xdna45y2hplj31ncf8a-glibc-2.40-36/lib/libc.so.6 in '??'
  from /nix/store/h7zcxabfxa7v5xdna45y2hplj31ncf8a-glibc-2.40-36/lib/libc.so.6 in '__libc_start_main'
  from /nix/store/2dvxh0p8mbaz7hmv2hl20cn9s81q3rys-crystal-1.15.0/bin/crystal in '_start'
  from ???
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

make: *** [Makefile:17: rtfm] Error 1

@MisileLab
Copy link
Contributor Author

is rtfm error crystal compiler bug?

@donovanglover
Copy link
Member

CC @UlyssesZh for ahk_x11. rtfm may be removed from nixpkgs soon.

@UlyssesZh
Copy link
Member

Hm? I didn't see anything about wait_readable when I scanned through the changelog of 1.15. I may look into this.

@MisileLab
Copy link
Contributor Author

Hm? I didn't see anything about wait_readable when I scanned through the changelog of 1.15. I may look into this.

I think crystal-lang/crystal#15374 is related to that.

@donovanglover
Copy link
Member

How about making those packages use crystal_1_14? ameba also lacks an active maintainer

@UlyssesZh
Copy link
Member

I realized that AHK_X11 needs Crystal 1.11 anyway to work around a bug (which is present in the current version in nixpkgs). I opened #378118 for that. After it's merged, ahk_x11 will be safe from this PR.

@donovanglover
Copy link
Member

1.15.1 is out now

@MisileLab MisileLab changed the title crystal_1_15: init at 1.15.0 crystal_1_15: init at 1.15.1 Feb 5, 2025
@MisileLab MisileLab marked this pull request as draft February 5, 2025 00:42
@MisileLab MisileLab marked this pull request as ready for review February 5, 2025 00:50
@MisileLab
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372897


x86_64-linux

❌ 2 packages failed to build:
  • ameba
  • rtfm
✅ 20 packages built:
  • ahk_x11
  • amqpcat
  • blahaj
  • collision
  • crystal (crystal_1_15)
  • crystal.bin (crystal_1_15.bin)
  • crystal.lib (crystal_1_15.lib)
  • crystal2nix
  • crystalline
  • gi-crystal
  • icr
  • invidious
  • kakoune-cr
  • lucky-cli
  • mint
  • oq
  • scry
  • shards (shards_0_17)
  • thicket
  • tmuxPlugins.fingers

@MisileLab
Copy link
Contributor Author

ameba has same error
rtfm error

Error target rtfm failed to compile:
Module validation failed: !dbg attachment points at wrong subprogram for function
!4315 = distinct !DISubprogram(name: "main", linkageName: "main", scope: !19, file: !19, line: 1, type: !5, scopeLine: 1, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition | DISPFlagOptimized, unit: !0)
ptr @main
  %status = alloca i32, align 4, !dbg !4316
!4316 = !DILocation(line: 8, column: 1, scope: !4317)
!4317 = distinct !DISubprogram(name: "main", linkageName: "main", scope: !4318, file: !4318, line: 8, type: !5, scopeLine: 8, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition | DISPFlagOptimized, unit: !0)
!4317 = distinct !DISubprogram(name: "main", linkageName: "main", scope: !4318, file: !4318, line: 8, type: !5, scopeLine: 8, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition | DISPFlagOptimized, unit: !0)
 (Exception)
  from /build/source/src/llvm/module.cr:83:9 in 'codegen'
  from /build/source/src/compiler/crystal/compiler.cr:220:15 in 'compile'
  from /build/source/src/compiler/crystal/command.cr:359:5 in 'run'
  from /build/source/src/compiler/crystal.cr:11:1 in '__crystal_main'
  from /build/source/src/crystal/main.cr:118:5 in 'main'
  from /build/source/src/crystal/system/unix/main.cr:10:3 in 'main'
  from /nix/store/h7zcxabfxa7v5xdna45y2hplj31ncf8a-glibc-2.40-36/lib/libc.so.6 in '??'
  from /nix/store/h7zcxabfxa7v5xdna45y2hplj31ncf8a-glibc-2.40-36/lib/libc.so.6 in '__libc_start_main'
  from /nix/store/wbx8v8v8k15rjqzjqc5bw3qyb4k778w4-crystal-1.15.1/bin/crystal in '_start'
  from ???
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

make: *** [Makefile:17: rtfm] Error 1

@donovanglover donovanglover mentioned this pull request Feb 5, 2025
13 tasks
@donovanglover
Copy link
Member

Does ameba build with the latest commit? Seems to build in their CI.

@MisileLab
Copy link
Contributor Author

Does ameba build with the latest commit? Seems to build in their CI.

I'll try it

@MisileLab
Copy link
Contributor Author

MisileLab commented Feb 5, 2025

Does ameba build with the latest commit? Seems to build in their CI.

bump ameba to 1.6.4 is enough

@MisileLab
Copy link
Contributor Author

#379614 will fix ameba

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thanks everyone.

@donovanglover donovanglover merged commit d6e2f08 into NixOS:master Feb 5, 2025
53 of 55 checks passed
@MisileLab MisileLab deleted the crystal branch February 5, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants