Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Nixpkgs lib-tests workflow #361447

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

JohnRTitor
Copy link
Contributor

Ofborg also does this.

JohnRTitor#1

Things done


Add a 👍 reaction to pull requests you find important.

@JohnRTitor JohnRTitor requested review from Mic92 and infinisil December 3, 2024 13:19
@github-actions github-actions bot added 6.topic: policy discussion 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Dec 3, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 3, 2024
@JohnRTitor JohnRTitor changed the title ci: add NixOS lib-tests workflow ci: add Nixpkgs lib-tests workflow Dec 3, 2024
@JohnRTitor JohnRTitor force-pushed the eval-lib-tests branch 2 times, most recently from 9c74910 to c992fa6 Compare December 3, 2024 13:47
@JohnRTitor
Copy link
Contributor Author

extra_nix_config: sandbox = true
- name: Building Nixpkgs lib-tests
run: |
nix-build --arg pkgs "import ./. {}" ./lib/tests/release.nix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use the pinned Nixpkgs version from the ci directory for pkgs, there's no need to exclude certain branches, because no dependencies should come from the Nixpkgs being tested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what would be the syntax for it, just use fetchFromGitHub? An example would be helpful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this nix-build --arg pkgs "(import ./ci/. {}).pkgs"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks.

.github/workflows/eval-lib-tests.yml Outdated Show resolved Hide resolved
.github/workflows/eval-lib-tests.yml Show resolved Hide resolved
.github/workflows/eval-lib-tests.yml Show resolved Hide resolved
@JohnRTitor
Copy link
Contributor Author

Since #361494 got merged, will rework this PR to use the get-merge-commit action.

Ofborg also does this.
Should be run on `lib/*` dirs

Signed-off-by: John Titor <[email protected]>
@JohnRTitor
Copy link
Contributor Author

@infinisil can we get this going? Or do you want me to create the giant main CI first (and turn others into reusable workflows)

@Mic92 Mic92 dismissed infinisil’s stale review December 6, 2024 16:19

has been addressed as far as I can see.

@Mic92 Mic92 merged commit 8aa3366 into NixOS:master Dec 6, 2024
32 checks passed
@infinisil
Copy link
Member

I don't always have time to review, but I really like the tempo we have going on here, and am totally fine with merging fast! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants