-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add Nixpkgs lib-tests workflow #361447
Conversation
ef7affc
to
97099a0
Compare
9c74910
to
c992fa6
Compare
Should be ready, seems to build fine. https://github.com/JohnRTitor/nixpkgs/actions/runs/12141031084/job/33852157941?pr=1 |
.github/workflows/eval-lib-tests.yml
Outdated
extra_nix_config: sandbox = true | ||
- name: Building Nixpkgs lib-tests | ||
run: | | ||
nix-build --arg pkgs "import ./. {}" ./lib/tests/release.nix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use the pinned Nixpkgs version from the ci directory for pkgs
, there's no need to exclude certain branches, because no dependencies should come from the Nixpkgs being tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what would be the syntax for it, just use fetchFromGitHub
? An example would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this nix-build --arg pkgs "(import ./ci/. {}).pkgs"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
c992fa6
to
28c976e
Compare
28c976e
to
16b7e6c
Compare
Since #361494 got merged, will rework this PR to use the get-merge-commit action. |
Ofborg also does this. Should be run on `lib/*` dirs Signed-off-by: John Titor <[email protected]>
16b7e6c
to
6da0724
Compare
@infinisil can we get this going? Or do you want me to create the giant main CI first (and turn others into reusable workflows) |
has been addressed as far as I can see.
I don't always have time to review, but I really like the tempo we have going on here, and am totally fine with merging fast! :D |
Ofborg also does this.
JohnRTitor#1
Things done
Add a 👍 reaction to pull requests you find important.