Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.soxr: fix build on x86_64-darwin #359539

Merged
merged 1 commit into from
Nov 28, 2024
Merged

python312Packages.soxr: fix build on x86_64-darwin #359539

merged 1 commit into from
Nov 28, 2024

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Nov 27, 2024

https://hydra.nixos.org/build/279984694

ZHF #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@azuwis
Copy link
Contributor Author

azuwis commented Nov 27, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359539

x86_64-linux

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • tts
  • tts.dist
❌ 12 packages failed to build:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.torchcrepe
  • python312Packages.torchcrepe.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
✅ 24 packages built:
  • pianotrans
  • pianotrans.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.soxr
  • python311Packages.soxr.dist
  • python311Packages.torch-audiomentations
  • python311Packages.torch-audiomentations.dist
  • python311Packages.torchcrepe
  • python311Packages.torchcrepe.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist
  • python312Packages.librosa
  • python312Packages.librosa.dist
  • python312Packages.piano-transcription-inference
  • python312Packages.piano-transcription-inference.dist
  • python312Packages.soxr
  • python312Packages.soxr.dist
  • python312Packages.torch-audiomentations
  • python312Packages.torch-audiomentations.dist
  • python312Packages.torchlibrosa
  • python312Packages.torchlibrosa.dist

x86_64-darwin

❌ 4 packages failed to build:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist
✅ 18 packages built:
  • pianotrans
  • pianotrans.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.soxr
  • python311Packages.soxr.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist
  • python312Packages.librosa
  • python312Packages.librosa.dist
  • python312Packages.piano-transcription-inference
  • python312Packages.piano-transcription-inference.dist
  • python312Packages.soxr
  • python312Packages.soxr.dist
  • python312Packages.torchlibrosa
  • python312Packages.torchlibrosa.dist

@azuwis azuwis marked this pull request as ready for review November 27, 2024 12:22
@azuwis azuwis added the backport release-24.11 Backport PR automatically label Nov 27, 2024
@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359539

x86_64-linux

x86_64-darwin

❌ 4 packages failed to build:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist
✅ 18 packages built:
  • pianotrans
  • pianotrans.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.soxr
  • python311Packages.soxr.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist
  • python312Packages.librosa
  • python312Packages.librosa.dist
  • python312Packages.piano-transcription-inference
  • python312Packages.piano-transcription-inference.dist
  • python312Packages.soxr
  • python312Packages.soxr.dist
  • python312Packages.torchlibrosa
  • python312Packages.torchlibrosa.dist

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • tts
  • tts.dist
❌ 14 packages failed to build:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.torchcrepe
  • python311Packages.torchcrepe.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.torchcrepe
  • python312Packages.torchcrepe.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
✅ 22 packages built:
  • pianotrans
  • pianotrans.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.soxr
  • python311Packages.soxr.dist
  • python311Packages.torch-audiomentations
  • python311Packages.torch-audiomentations.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist
  • python312Packages.librosa
  • python312Packages.librosa.dist
  • python312Packages.piano-transcription-inference
  • python312Packages.piano-transcription-inference.dist
  • python312Packages.soxr
  • python312Packages.soxr.dist
  • python312Packages.torch-audiomentations
  • python312Packages.torch-audiomentations.dist
  • python312Packages.torchlibrosa
  • python312Packages.torchlibrosa.dist

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 27, 2024
@azuwis azuwis changed the title python312Packages.nanobind: fix build on x86_64-darwin python312Packages.soxr: fix build on x86_64-darwin Nov 28, 2024
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 28, 2024
@Scrumplex Scrumplex merged commit 8c5c3e5 into NixOS:master Nov 28, 2024
22 of 23 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
1 task
@azuwis azuwis deleted the push-ttkqyyzqsqnt branch November 29, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azuwis @Scrumplex @wegank