Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fpc: fix darwin build #359218

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fpc: fix darwin build #359218

merged 1 commit into from
Nov 27, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Nov 26, 2024 •
edited
Loading

needs backport release-24.11 label

ZHF: #352882
https://hydra.nixos.org/build/277877149

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 27, 2024
@ofborg ofborg bot requested a review from 7c6f434c November 27, 2024 01:34
@7c6f434c 7c6f434c added the backport release-24.11 Backport PR automatically label Nov 27, 2024
@7c6f434c 7c6f434c merged commit 43e8808 into NixOS:master Nov 27, 2024
41 of 43 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Merged
1 task
@paparodeo paparodeo deleted the fpc-fix branch November 27, 2024 05:48
@Rhys-T Rhys-T mentioned this pull request Nov 30, 2024
Open
@wolfgangwalther wolfgangwalther mentioned this pull request Dec 1, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paparodeo @7c6f434c