Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etterna: init at 8deab33 #353956

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

etterna: init at 8deab33 #353956

wants to merge 4 commits into from

Conversation

mibmo
Copy link
Contributor

@mibmo mibmo commented Nov 6, 2024

This PR is a draft as it's pinned to a non-release version of Etterna, and the maintainer specifically asked to not package in-development versions, but they did approve of packaging it without making it generally available - hence this draft PR, which can be used by those who don't want to wait.

But that is to say; do not report bugs to upstream

unless you're completely sure they're actually upstream Etterna bugs, not already tracked, not just a bi-product of whatever is happening in the develop branch, and not just the product of the shenanigans this package does to make Etterna work.

okay; the normal PR description starts here

Beta client version of Etterna.

Pinned at the same commit that the beta clients are so that etternagame/etterna#1282 is merged, and packaging is seamless -- it should be updated when the next stable release happens.

Would really like to get the sketchy installPhase wrapper fixed, just not sure what the best way would be - I'd definitely prefer to use makeWrapper, but am unable to figure out how I'd make it refer to $HOME then.

Should probably also try XDG_DATA_HOME before defaulting to $HOME/.local/share? Again, feedback very much welcome!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

mibmo added 2 commits November 6, 2024 04:47
pegged to same commit as the released beta clients.
should rewrite so `overrideAttrs` works better
the wrapper is really weird though and i don't like it.
due to whitespace preceding shebang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant