Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft as it's pinned to a non-release version of Etterna, and the maintainer specifically asked to not package in-development versions, but they did approve of packaging it without making it generally available - hence this draft PR, which can be used by those who don't want to wait.
But that is to say; do not report bugs to upstream
unless you're completely sure they're actually upstream Etterna bugs, not already tracked, not just a bi-product of whatever is happening in the
develop
branch, and not just the product of the shenanigans this package does to make Etterna work.okay; the normal PR description starts here
Beta client version of Etterna.
Pinned at the same commit that the beta clients are so that etternagame/etterna#1282 is merged, and packaging is seamless -- it should be updated when the next stable release happens.
Would really like to get the sketchy
installPhase
wrapper fixed, just not sure what the best way would be - I'd definitely prefer to usemakeWrapper
, but am unable to figure out how I'd make it refer to$HOME
then.Should probably also try
XDG_DATA_HOME
before defaulting to$HOME/.local/share
? Again, feedback very much welcome!Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.