Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsyncd: update xnu include path; fix darwin #352506

Merged
merged 1 commit into from
Nov 1, 2024
Merged

lsyncd: update xnu include path; fix darwin #352506

merged 1 commit into from
Nov 1, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Oct 31, 2024 •
edited
Loading

https://hydra.nixos.org/build/276194930/log/tail

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 31, 2024
@paparodeo paparodeo changed the base branch from staging-next to master October 31, 2024 07:37
@ofborg ofborg bot requested a review from bobvanderlinden October 31, 2024 09:57
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 31, 2024
bobvanderlinden
bobvanderlinden approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@bobvanderlinden bobvanderlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test this, but it does align with how other packages use xnu 👍

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 31, 2024
@tjni
Copy link
Contributor

tjni commented Nov 1, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352506

aarch64-darwin

✅ 1 package built:
  • lsyncd

@tjni tjni merged commit b2f76a0 into NixOS:master Nov 1, 2024
42 of 43 checks passed
@paparodeo paparodeo deleted the lsyncd-fix branch November 1, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvanderlinden bobvanderlinden bobvanderlinden approved these changes

@tjni tjni tjni approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paparodeo @tjni @bobvanderlinden @wegank