Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains-mono: build from source #349612

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thecaralice
Copy link
Contributor

Build JetBrains Mono from source according to README. This allows patching font sources for example.
Currently broken on darwin, hence drafted.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vinnymeller
Copy link
Contributor

vinnymeller commented Oct 24, 2024

not sure if you've already investigated but noting here in case not / for others:

build log on aarch64-darwin:
NIXPKGS_ALLOW_BROKEN=1 nix build 'github:thecaralice/nixpkgs/jbmono-src#jetbrains-mono' --impure

error: builder for '/nix/store/cfx2drcj9b4bbrz8v867nl9n3imn22qh-python3.12-jaraco-path-3.7.1.drv' failed with exit code 1;
       last 25 log lines:
       > running install
       > running install_lib
       > creating build/bdist.macosx-11.0-arm64
       > creating build/bdist.macosx-11.0-arm64/wheel
       > creating build/bdist.macosx-11.0-arm64/wheel/jaraco
       > copying build/lib/jaraco/path.py -> build/bdist.macosx-11.0-arm64/wheel/jaraco
       > running install_egg_info
       > Copying jaraco.path.egg-info to build/bdist.macosx-11.0-arm64/wheel/jaraco.path-3.7.1-py3.12.egg-info
       > running install_scripts
       > creating build/bdist.macosx-11.0-arm64/wheel/jaraco.path-3.7.1.dist-info/WHEEL
       > creating '/private/tmp/nix-build-python3.12-jaraco-path-3.7.1.drv-0/source/dist/.tmp-mv6havsw/jaraco.path-3.7.1-py3-none-any.whl' and adding 'build/bdist.macosx-11.0-arm64/wheel' to it
       > adding 'jaraco/path.py'
       > adding 'jaraco.path-3.7.1.dist-info/LICENSE'
       > adding 'jaraco.path-3.7.1.dist-info/METADATA'
       > adding 'jaraco.path-3.7.1.dist-info/WHEEL'
       > adding 'jaraco.path-3.7.1.dist-info/top_level.txt'
       > adding 'jaraco.path-3.7.1.dist-info/RECORD'
       > removing build/bdist.macosx-11.0-arm64/wheel
       > Successfully built jaraco.path-3.7.1-py3-none-any.whl
       > Finished creating a wheel...
       > Finished executing pypaBuildPhase
       > Running phase: pythonRuntimeDepsCheckHook
       > Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for jaraco.path-3.7.1-py3-none-any.whl
       >   - pyobjc not installed
       For full logs, run 'nix log /nix/store/cfx2drcj9b4bbrz8v867nl9n3imn22qh-python3.12-jaraco-path-3.7.1.drv'.
error: 1 dependencies of derivation '/nix/store/55bhrrahbp582xn6nrpx4iygss70frna-python3.12-distutils-72.1.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vmgx9z1kp5d2k4rw5j5r834aqigw7wzl-python3.12-cffsubr-0.3.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/pfj03nm4rb5x5fc87dlmcy9lazz1v8vr-python3.12-ttfautohint-py-0.5.1.drv' failed to build
error: 1 dependencies of derivation '/nix/store/i3jsparrpfanpwb7i3l3ipy88n4mj5fc-python3.12-gftools-0.9.71.drv' failed to build
error: 1 dependencies of derivation '/nix/store/y8mz86gdkwvi2a0sh9l07gfmy76541xy-jetbrains-mono-2.304.drv' failed to build

root issue seems to be that jaraco-path is broken on darwin due to the missing pyobjc dependency, with an open issue here: #346003 and open pr for pyobjc here: #336801

once pyobjc is in, distutils should work on darwin, and then maybe it works?

on linux looks good 👍

@vinnymeller
Copy link
Contributor

LOL didn't notice you were the one that made the comment on the jaraco-path issue. well anyways documented here in case anyone else comes along 🙂

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1 10.rebuild-linux: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants