Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.cmp-nixpkgs-maintainers: init at 2024-10-12 #348096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vimPlugins.cmp-nixpkgs-maintainers: init at 2024-10-12 #348096

wants to merge 1 commit into from
+18 −0

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Oct 12, 2024 •
edited
Loading

Things done

Add cmp-nixpkgs-maintainers, an nvim-cmp source completing nixpkgs maintainers github handles.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from figsoda October 12, 2024 13:46
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348096

x86_64-linux

✅ 2 packages built:
  • vimPlugins.cmp-nixpkgs-maintainers
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.cmp-nixpkgs-maintainers
  • vimPluginsUpdater

x86_64-darwin

✅ 2 packages built:
  • vimPlugins.cmp-nixpkgs-maintainers
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.cmp-nixpkgs-maintainers
  • vimPluginsUpdater

@PerchunPak
Copy link
Member

@ofborg eval

PerchunPak
PerchunPak approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it always results in this error, but I guess this is not something that should be fixed inside nixpkgs

image

@GaetanLepage
Copy link
Contributor Author

For me, it always results in this error, but I guess this is not something that should be fixed inside nixpkgs

Fixed upstream and updated the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda Awaiting requested review from figsoda

@teto teto Awaiting requested review from teto

@PerchunPak PerchunPak Awaiting requested review from PerchunPak

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaetanLepage @PerchunPak